[MediaWiki-commits] [Gerrit] marvin[master]: Chore: disable powered by Express header

2017-12-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394778 )

Change subject: Chore: disable powered by Express header
..


Chore: disable powered by Express header

Marvin is open source but it seems to be recommended practice to disable
this custom header.

http://expressjs.com/en/advanced/best-practice-security.html#at-a-minimum-disable-x-powered-by-header

Change-Id: I5dd86770068717beb3c4a5fb92d21d783464e702
---
M src/server/index.tsx
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/server/index.tsx b/src/server/index.tsx
index 118b9fa..4d950fc 100644
--- a/src/server/index.tsx
+++ b/src/server/index.tsx
@@ -10,6 +10,10 @@
 
 const server = express();
 
+// Disable useless header.
+// 
http://expressjs.com/en/advanced/best-practice-security.html#at-a-minimum-disable-x-powered-by-header
+server.disable("x-powered-by");
+
 server.use(compression());
 
 server.use("/public", express.static("dist/public"));

-- 
To view, visit https://gerrit.wikimedia.org/r/394778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5dd86770068717beb3c4a5fb92d21d783464e702
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Sniedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: disable powered by Express header

2017-12-02 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394778 )

Change subject: Chore: disable powered by Express header
..

Chore: disable powered by Express header

Marvin is open source but it seems to be recommended practice to disable
this custom header.

http://expressjs.com/en/advanced/best-practice-security.html#at-a-minimum-disable-x-powered-by-header

Change-Id: I5dd86770068717beb3c4a5fb92d21d783464e702
---
M src/server/index.tsx
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/78/394778/1

diff --git a/src/server/index.tsx b/src/server/index.tsx
index 118b9fa..4d950fc 100644
--- a/src/server/index.tsx
+++ b/src/server/index.tsx
@@ -10,6 +10,10 @@
 
 const server = express();
 
+// Disable useless header.
+// 
http://expressjs.com/en/advanced/best-practice-security.html#at-a-minimum-disable-x-powered-by-header
+server.disable("x-powered-by");
+
 server.use(compression());
 
 server.use("/public", express.static("dist/public"));

-- 
To view, visit https://gerrit.wikimedia.org/r/394778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dd86770068717beb3c4a5fb92d21d783464e702
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits