[MediaWiki-commits] [Gerrit] marvin[master]: Doc: Use not-null markers on server/templates/page jsdoc

2017-08-09 Thread Niedzielski (Code Review) 
Niedzielski has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370671 )

Change subject: Doc: Use not-null markers on server/templates/page jsdoc
..


Doc: Use not-null markers on server/templates/page jsdoc

Change-Id: Ifb534d78fc212f9e8ddc8a57a1154f0da864d507
---
M src/server/templates/page.js
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Niedzielski: Verified; Looks good to me, approved



diff --git a/src/server/templates/page.js b/src/server/templates/page.js
index dbc26d1..dba5ca4 100644
--- a/src/server/templates/page.js
+++ b/src/server/templates/page.js
@@ -1,10 +1,10 @@
 /**
  * Render a full HTML page
- * @param {Object} params
+ * @param {!Object} params
  * @param {?string} params.title Title of the page
  * @param {string} [params.body = ""] HTML to render in the body of the page
- * @param {Object.>} params.assets Manifest of 
filename entry points to bundled assets.
- * @return {string} HTML
+ * @param {!Object.>} params.assets Manifest 
of filename entry points to bundled assets.
+ * @return {!string} HTML
  */
 module.exports = function page({ body = "", assets, title }) {
   return `

-- 
To view, visit https://gerrit.wikimedia.org/r/370671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb534d78fc212f9e8ddc8a57a1154f0da864d507
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Doc: Use not-null markers on server/templates/page jsdoc

2017-08-08 Thread Jhernandez (Code Review) 
Jhernandez has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370671 )

Change subject: Doc: Use not-null markers on server/templates/page jsdoc
..

Doc: Use not-null markers on server/templates/page jsdoc

Change-Id: Ifb534d78fc212f9e8ddc8a57a1154f0da864d507
---
M src/server/templates/page.js
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/71/370671/1

diff --git a/src/server/templates/page.js b/src/server/templates/page.js
index dbc26d1..19d3f6b 100644
--- a/src/server/templates/page.js
+++ b/src/server/templates/page.js
@@ -1,10 +1,10 @@
 /**
  * Render a full HTML page
- * @param {Object} params
+ * @param {!Object} params
  * @param {?string} params.title Title of the page
- * @param {string} [params.body = ""] HTML to render in the body of the page
- * @param {Object.>} params.assets Manifest of 
filename entry points to bundled assets.
- * @return {string} HTML
+ * @param {!string} [params.body = ""] HTML to render in the body of the page
+ * @param {!Object.>} params.assets Manifest 
of filename entry points to bundled assets.
+ * @return {!string} HTML
  */
 module.exports = function page({ body = "", assets, title }) {
   return `

-- 
To view, visit https://gerrit.wikimedia.org/r/370671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb534d78fc212f9e8ddc8a57a1154f0da864d507
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits