[MediaWiki-commits] [Gerrit] marvin[master]: Hygiene: Format package.json like npm does

2017-08-09 Thread Jhernandez (Code Review) 
Jhernandez has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370670 )

Change subject: Hygiene: Format package.json like npm does
..


Hygiene: Format package.json like npm does

npm init generated the package.json in a format and then npm install
changes it to something different.

This patch formats package.json like npm install does, so that when you
run npm install it doesn't modify your local copy.

Change-Id: I04ddf111f9d21f0f74576eba95507cad5f711bc1
---
M package.json
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Niedzielski: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index f76b976..956d5d0 100644
--- a/package.json
+++ b/package.json
@@ -16,13 +16,21 @@
 "precommit": "lint-staged"
   },
   "lint-staged": {
-"*.js": ["npm test"]
+"*.js": [
+  "npm test"
+]
   },
   "repository": {
 "type": "git",
 "url": "git+https://github.com/niedzielski/marvin.git;
   },
-  "keywords": ["mediawiki", "wikimedia", "web", "node", "pwa"],
+  "keywords": [
+"mediawiki",
+"wikimedia",
+"web",
+"node",
+"pwa"
+  ],
   "author": "Wikimedia Foundation",
   "license": "GPL-2.0",
   "bugs": {

-- 
To view, visit https://gerrit.wikimedia.org/r/370670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04ddf111f9d21f0f74576eba95507cad5f711bc1
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Hygiene: Format package.json like npm does

2017-08-08 Thread Jhernandez (Code Review) 
Jhernandez has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370670 )

Change subject: Hygiene: Format package.json like npm does
..

Hygiene: Format package.json like npm does

npm init generated the package.json in a format and then npm install
changes it to something different.

This patch formats package.json like npm install does, so that when you
run npm install it doesn't modify your local copy.

Change-Id: I04ddf111f9d21f0f74576eba95507cad5f711bc1
---
M package.json
1 file changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/70/370670/1

diff --git a/package.json b/package.json
index f76b976..956d5d0 100644
--- a/package.json
+++ b/package.json
@@ -16,13 +16,21 @@
 "precommit": "lint-staged"
   },
   "lint-staged": {
-"*.js": ["npm test"]
+"*.js": [
+  "npm test"
+]
   },
   "repository": {
 "type": "git",
 "url": "git+https://github.com/niedzielski/marvin.git;
   },
-  "keywords": ["mediawiki", "wikimedia", "web", "node", "pwa"],
+  "keywords": [
+"mediawiki",
+"wikimedia",
+"web",
+"node",
+"pwa"
+  ],
   "author": "Wikimedia Foundation",
   "license": "GPL-2.0",
   "bugs": {

-- 
To view, visit https://gerrit.wikimedia.org/r/370670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I04ddf111f9d21f0f74576eba95507cad5f711bc1
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits