Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384111 )
Change subject: POC: Chore: upgrade Webpack v3.6.0 → 3.7.1 ...................................................................... POC: Chore: upgrade Webpack v3.6.0 → 3.7.1 This version dramatically increases bundle sizes. • deepChildren option added to CommonChunkPlugin (applied in this patch but no change observed). • New ContextExclusionPlugin to exclude files in a context. • And it sounds like some important (but poorly summarized) fixes. https://github.com/webpack/webpack/releases/tag/v3.7.0 https://github.com/webpack/webpack/releases/tag/v3.7.1 Change-Id: I3a91ee0c214624f3f8f3c38f9c51317ae6d9b01d --- M package-lock.json M package.json M webpack.config.ts 3 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/11/384111/1 diff --git a/package-lock.json b/package-lock.json index 3107df2..f089417 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7100,9 +7100,9 @@ } }, "webpack": { - "version": "3.6.0", - "resolved": "https://registry.npmjs.org/webpack/-/webpack-3.6.0.tgz";, - "integrity": "sha512-OsHT3D0W0KmPPh60tC7asNnOmST6bKTiR90UyEdT9QYoaJ4OYN4Gg7WK1k3VxHK07ZoiYWPsKvlS/gAjwL/vRA==", + "version": "3.7.1", + "resolved": "https://registry.npmjs.org/webpack/-/webpack-3.7.1.tgz";, + "integrity": "sha512-8MR+gVfxsvtx4J1UlbRGkUJEpDQUBFmisRmpPO5cVLgF21R8UMChX39OOjDz63a+m/iswGoqATszdZB2VCsYuA==", "dev": true, "requires": { "acorn": "5.1.1", diff --git a/package.json b/package.json index ff2b3c2..5edf547 100644 --- a/package.json +++ b/package.json @@ -89,7 +89,7 @@ "ts-node": "3.3.0", "typescript": "2.5.3", "typescript-eslint-parser": "8.0.0", - "webpack": "3.6.0", + "webpack": "3.7.1", "webpack-dev-server": "2.9.1", "wikimedia-ui-base": "0.9.2" } diff --git a/webpack.config.ts b/webpack.config.ts index e5c960c..aa064cc 100644 --- a/webpack.config.ts +++ b/webpack.config.ts @@ -247,6 +247,7 @@ // https://webpack.js.org/plugins/commons-chunk-plugin/#move-common-modules-into-the-parent-chunk new webpack.optimize.CommonsChunkPlugin({ children: true, + ...({ deepChildren: true } as {}), // Include all descendants too. minChunks: 3 }), -- To view, visit https://gerrit.wikimedia.org/r/384111 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a91ee0c214624f3f8f3c38f9c51317ae6d9b01d Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
