[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [search] Remove more dead code

2016-11-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: [search] Remove more dead code
..


[search] Remove more dead code

This code in SpecialSearch looks to still be around from the days where
there was a feature that go would send you to directly to an edit page,
rather than showing search results. That feature no longer exists, so
remove the related code.

Change-Id: If5b064b08a6258bfab31ab8f8b62c1d7283c8912
---
M includes/specials/SpecialSearch.php
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialSearch.php 
b/includes/specials/SpecialSearch.php
index f301e7c..e7a8677 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -234,11 +234,6 @@
 
return;
}
-   # No match, generate an edit URL
-   $title = Title::newFromText( $term );
-   if ( !is_null( $title ) ) {
-   Hooks::run( 'SpecialSearchNogomatch', [ &$title ] );
-   }
$this->showResults( $term );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/320305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5b064b08a6258bfab31ab8f8b62c1d7283c8912
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [search] Remove more dead code

2016-11-07 Thread EBernhardson (Code Review)
EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320305

Change subject: [search] Remove more dead code
..

[search] Remove more dead code

This code in SpecialSearch looks to still be around from the days where
there was a feature that go would send you to directly to an edit page,
rather than showing search results. That feature no longer exists, so
remove the related code.

Change-Id: If5b064b08a6258bfab31ab8f8b62c1d7283c8912
---
M includes/specials/SpecialSearch.php
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/05/320305/1

diff --git a/includes/specials/SpecialSearch.php 
b/includes/specials/SpecialSearch.php
index 9968f2e..599d526 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -234,11 +234,6 @@
 
return;
}
-   # No match, generate an edit URL
-   $title = Title::newFromText( $term );
-   if ( !is_null( $title ) ) {
-   Hooks::run( 'SpecialSearchNogomatch', [ &$title ] );
-   }
$this->showResults( $term );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/320305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b064b08a6258bfab31ab8f8b62c1d7283c8912
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits