[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add googleweblight to JS blacklist

2016-12-14 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327250 )

Change subject: Add googleweblight to JS blacklist
..

Add googleweblight to JS blacklist

Google runs JS on their proxy servers and outputs a page which may
be broken in creative ways (e.g. clicking anywhere triggers the
fundraising banner). Treat them as a non-JS browser to minimize
bugginess.

Currently broken with CentralNotice banner:
https://googleweblight.com/?lite_url=https://en.wikipedia.org

Images below the fold never load:
https://googleweblight.com/?lite_url=https://en.wikipedia.org/wiki/Barack_Obama

Bug: T152602
Change-Id: Ibf4e42fdd71eb4180743e4f08c995ed416a2db2f
---
M resources/src/startup.js
M tests/qunit/suites/resources/startup.test.js
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/50/327250/1

diff --git a/resources/src/startup.js b/resources/src/startup.js
index 82a00bc..20818d2 100644
--- a/resources/src/startup.js
+++ b/resources/src/startup.js
@@ -75,7 +75,7 @@
// support in the modern run-time.
// Note: Please extend the regex instead of adding new ones
!(
-   ua.match( 
/webOS\/1\.[0-4]|SymbianOS|Series60|NetFront|Opera 
Mini|S40OviBrowser|MeeGo|Android.+Glass|^Mozilla\/5\.0 .+ Gecko\/$/ ) ||
+   ua.match( 
/webOS\/1\.[0-4]|SymbianOS|Series60|NetFront|Opera 
Mini|S40OviBrowser|MeeGo|Android.+Glass|^Mozilla\/5\.0 .+ 
Gecko\/$|googleweblight/ ) ||
ua.match( /PlayStation/i )
)
);
diff --git a/tests/qunit/suites/resources/startup.test.js 
b/tests/qunit/suites/resources/startup.test.js
index 045b633..e6e798b 100644
--- a/tests/qunit/suites/resources/startup.test.js
+++ b/tests/qunit/suites/resources/startup.test.js
@@ -139,7 +139,9 @@
// MeeGo
'Mozilla/5.0 (MeeGo; NokiaN9) AppleWebKit/534.13 
(KHTML, like Gecko) NokiaBrowser/8.5.0 Mobile Safari/534.13',
// UC Mini (speed mode on)
-   'Mozilla/5.0 (X11; U; Linux i686; zh-CN; r:1.2.3.4) 
Gecko/'
+   'Mozilla/5.0 (X11; U; Linux i686; zh-CN; r:1.2.3.4) 
Gecko/',
+   // Google Web Light proxy
+   'Mozilla/5.0 (Linux; Android 4.2.1; en-us; Nexus 5 
Build/JOP40D) AppleWebKit/535.19 (KHTML, like Gecko; googleweblight) 
Chrome/38.0.1025.166 Mobile Safari/535.19'
]
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/327250
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf4e42fdd71eb4180743e4f08c995ed416a2db2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add googleweblight to JS blacklist

2016-12-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327043 )

Change subject: Add googleweblight to JS blacklist
..


Add googleweblight to JS blacklist

Google runs JS on their proxy servers and outputs a page which may
be broken in creative ways (e.g. clicking anywhere triggers the
fundraising banner). Treat them as a non-JS browser to minimize
bugginess.

Currently broken with CentralNotice banner:
https://googleweblight.com/?lite_url=https://en.wikipedia.org

Images below the fold never load:
https://googleweblight.com/?lite_url=https://en.wikipedia.org/wiki/Barack_Obama

Bug: T152602
Change-Id: Ia277ab51634b770a950616a842bedb29fcbf1f12
---
M resources/src/startup.js
M tests/qunit/suites/resources/startup.test.js
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/src/startup.js b/resources/src/startup.js
index 82a00bc..20818d2 100644
--- a/resources/src/startup.js
+++ b/resources/src/startup.js
@@ -75,7 +75,7 @@
// support in the modern run-time.
// Note: Please extend the regex instead of adding new ones
!(
-   ua.match( 
/webOS\/1\.[0-4]|SymbianOS|Series60|NetFront|Opera 
Mini|S40OviBrowser|MeeGo|Android.+Glass|^Mozilla\/5\.0 .+ Gecko\/$/ ) ||
+   ua.match( 
/webOS\/1\.[0-4]|SymbianOS|Series60|NetFront|Opera 
Mini|S40OviBrowser|MeeGo|Android.+Glass|^Mozilla\/5\.0 .+ 
Gecko\/$|googleweblight/ ) ||
ua.match( /PlayStation/i )
)
);
diff --git a/tests/qunit/suites/resources/startup.test.js 
b/tests/qunit/suites/resources/startup.test.js
index 045b633..e6e798b 100644
--- a/tests/qunit/suites/resources/startup.test.js
+++ b/tests/qunit/suites/resources/startup.test.js
@@ -139,7 +139,9 @@
// MeeGo
'Mozilla/5.0 (MeeGo; NokiaN9) AppleWebKit/534.13 
(KHTML, like Gecko) NokiaBrowser/8.5.0 Mobile Safari/534.13',
// UC Mini (speed mode on)
-   'Mozilla/5.0 (X11; U; Linux i686; zh-CN; r:1.2.3.4) 
Gecko/'
+   'Mozilla/5.0 (X11; U; Linux i686; zh-CN; r:1.2.3.4) 
Gecko/',
+   // Google Web Light proxy
+   'Mozilla/5.0 (Linux; Android 4.2.1; en-us; Nexus 5 
Build/JOP40D) AppleWebKit/535.19 (KHTML, like Gecko; googleweblight) 
Chrome/38.0.1025.166 Mobile Safari/535.19'
]
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/327043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia277ab51634b770a950616a842bedb29fcbf1f12
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add googleweblight to JS blacklist

2016-12-13 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327043 )

Change subject: Add googleweblight to JS blacklist
..

Add googleweblight to JS blacklist

Google runs JS on their proxy servers and outputs a page which may
be broken in creative ways (e.g. clicking anywhere triggers the
fundraising banner). Treat them as a non-JS browser to minimize
bugginess.

Bug: T152602
Change-Id: Ia277ab51634b770a950616a842bedb29fcbf1f12
---
M resources/src/startup.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/43/327043/1

diff --git a/resources/src/startup.js b/resources/src/startup.js
index 82a00bc..20818d2 100644
--- a/resources/src/startup.js
+++ b/resources/src/startup.js
@@ -75,7 +75,7 @@
// support in the modern run-time.
// Note: Please extend the regex instead of adding new ones
!(
-   ua.match( 
/webOS\/1\.[0-4]|SymbianOS|Series60|NetFront|Opera 
Mini|S40OviBrowser|MeeGo|Android.+Glass|^Mozilla\/5\.0 .+ Gecko\/$/ ) ||
+   ua.match( 
/webOS\/1\.[0-4]|SymbianOS|Series60|NetFront|Opera 
Mini|S40OviBrowser|MeeGo|Android.+Glass|^Mozilla\/5\.0 .+ 
Gecko\/$|googleweblight/ ) ||
ua.match( /PlayStation/i )
)
);

-- 
To view, visit https://gerrit.wikimedia.org/r/327043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia277ab51634b770a950616a842bedb29fcbf1f12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits