[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add urlencode for URL encoding of lang values

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365290 )

Change subject: Add urlencode for URL encoding of lang values
..


Add urlencode for URL encoding of lang values

Change-Id: If7d21223536d1873b3bfed154649d3dcb9850f9b
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Anomie: Looks good to me, approved



diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 5c048a2..0600642 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -761,7 +761,7 @@
if ( $this->showCreateAccountLink() ) {
# Pass any language selection on to the mode switch link
if ( $this->mLanguage ) {
-   $linkq .= '=' . $this->mLanguage;
+   $linkq .= '=' . urlencode( 
$this->mLanguage );
}
// Supply URL, login template creates the button.
$template->set( 'createOrLoginHref', 
$titleObj->getLocalURL( $linkq ) );
@@ -1149,7 +1149,7 @@
$linkq = 
$this->getReturnToQueryStringFragment();
// Pass any language selection on to the mode 
switch link
if ( $this->mLanguage ) {
-   $linkq .= '=' . 
$this->mLanguage;
+   $linkq .= '=' . urlencode( 
$this->mLanguage );
}
$loggedIn = $this->getUser()->isLoggedIn();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7d21223536d1873b3bfed154649d3dcb9850f9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add urlencode for URL encoding of lang values

[Fomafix (Code Review)]

Fomafix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365290 )

Change subject: Add urlencode for URL encoding of lang values
..

Add urlencode for URL encoding of lang values

Change-Id: If7d21223536d1873b3bfed154649d3dcb9850f9b
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/365290/1

diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 5c048a2..0600642 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -761,7 +761,7 @@
if ( $this->showCreateAccountLink() ) {
# Pass any language selection on to the mode switch link
if ( $this->mLanguage ) {
-   $linkq .= '=' . $this->mLanguage;
+   $linkq .= '=' . urlencode( 
$this->mLanguage );
}
// Supply URL, login template creates the button.
$template->set( 'createOrLoginHref', 
$titleObj->getLocalURL( $linkq ) );
@@ -1149,7 +1149,7 @@
$linkq = 
$this->getReturnToQueryStringFragment();
// Pass any language selection on to the mode 
switch link
if ( $this->mLanguage ) {
-   $linkq .= '=' . 
$this->mLanguage;
+   $linkq .= '=' . urlencode( 
$this->mLanguage );
}
$loggedIn = $this->getUser()->isLoggedIn();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7d21223536d1873b3bfed154649d3dcb9850f9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add urlencode for URL encoding of lang values

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362946 )

Change subject: Add urlencode for URL encoding of lang values
..


Add urlencode for URL encoding of lang values

Change-Id: I3ebeff2b947543a40b502403b47346a1b9a4
---
M includes/filerepo/FileRepo.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/includes/filerepo/FileRepo.php b/includes/filerepo/FileRepo.php
index 8edf81f..f89d96b 100644
--- a/includes/filerepo/FileRepo.php
+++ b/includes/filerepo/FileRepo.php
@@ -776,7 +776,7 @@
public function getDescriptionRenderUrl( $name, $lang = null ) {
$query = 'action=render';
if ( !is_null( $lang ) ) {
-   $query .= '=' . $lang;
+   $query .= '=' . urlencode( $lang );
}
if ( isset( $this->scriptDirUrl ) ) {
return $this->makeUrl(

-- 
To view, visit https://gerrit.wikimedia.org/r/362946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ebeff2b947543a40b502403b47346a1b9a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add urlencode for URL encoding of lang values

[Fomafix (Code Review)]

Fomafix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362946 )

Change subject: Add urlencode for URL encoding of lang values
..

Add urlencode for URL encoding of lang values

Change-Id: I3ebeff2b947543a40b502403b47346a1b9a4
---
M includes/filerepo/FileRepo.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/46/362946/1

diff --git a/includes/filerepo/FileRepo.php b/includes/filerepo/FileRepo.php
index 8edf81f..f89d96b 100644
--- a/includes/filerepo/FileRepo.php
+++ b/includes/filerepo/FileRepo.php
@@ -776,7 +776,7 @@
public function getDescriptionRenderUrl( $name, $lang = null ) {
$query = 'action=render';
if ( !is_null( $lang ) ) {
-   $query .= '=' . $lang;
+   $query .= '=' . urlencode( $lang );
}
if ( isset( $this->scriptDirUrl ) ) {
return $this->makeUrl(

-- 
To view, visit https://gerrit.wikimedia.org/r/362946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ebeff2b947543a40b502403b47346a1b9a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits