[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Do not run CollationFaTest if 'intl' is not loaded
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/378420 ) Change subject: Do not run CollationFaTest if 'intl' is not loaded .. Do not run CollationFaTest if 'intl' is not loaded Bug: T176040 Change-Id: I6b19bf1123d4dca5a1c8e002c0de65bab2138180 --- M tests/phpunit/includes/collation/CollationFaTest.php 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/includes/collation/CollationFaTest.php b/tests/phpunit/includes/collation/CollationFaTest.php index f230197..53a4f7b 100644 --- a/tests/phpunit/includes/collation/CollationFaTest.php +++ b/tests/phpunit/includes/collation/CollationFaTest.php @@ -7,6 +7,13 @@ * against a random version of libicu */ + public function setUp() { + parent::setUp(); + if ( !extension_loaded( 'intl' ) ) { + $this->markTestSkipped( "PHP extension 'intl' is not loaded, skipping." ); + } + } + /** * @dataProvider provideGetFirstLetter */ -- To view, visit https://gerrit.wikimedia.org/r/378420 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b19bf1123d4dca5a1c8e002c0de65bab2138180 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: HujiGerrit-Reviewer: Bartosz Dziewoński Gerrit-Reviewer: Brian Wolff Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Do not run CollationFaTest if 'intl' is not loaded
Huji has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378420 ) Change subject: Do not run CollationFaTest if 'intl' is not loaded .. Do not run CollationFaTest if 'intl' is not loaded Bug: T176040 Change-Id: I6b19bf1123d4dca5a1c8e002c0de65bab2138180 --- M tests/phpunit/includes/collation/CollationFaTest.php 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/20/378420/1 diff --git a/tests/phpunit/includes/collation/CollationFaTest.php b/tests/phpunit/includes/collation/CollationFaTest.php index f230197..53a4f7b 100644 --- a/tests/phpunit/includes/collation/CollationFaTest.php +++ b/tests/phpunit/includes/collation/CollationFaTest.php @@ -7,6 +7,13 @@ * against a random version of libicu */ + public function setUp() { + parent::setUp(); + if ( !extension_loaded( 'intl' ) ) { + $this->markTestSkipped( "PHP extension 'intl' is not loaded, skipping." ); + } + } + /** * @dataProvider provideGetFirstLetter */ -- To view, visit https://gerrit.wikimedia.org/r/378420 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b19bf1123d4dca5a1c8e002c0de65bab2138180 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Huji___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits