jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398205 )
Change subject: Fix manual IN queries in checkStorage.php
......................................................................
Fix manual IN queries in checkStorage.php
Bug: T182689
Change-Id: Ifca7bd6d0385dd470cddc483f4641eeb2832580c
---
M maintenance/storage/checkStorage.php
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/storage/checkStorage.php
b/maintenance/storage/checkStorage.php
index 4071a06..6348e96 100644
--- a/maintenance/storage/checkStorage.php
+++ b/maintenance/storage/checkStorage.php
@@ -208,7 +208,9 @@
$blobsTable = $this->dbStore->getTable(
$extDb );
$res = $extDb->select( $blobsTable,
[ 'blob_id' ],
- [ 'blob_id IN( ' . implode(
',', $blobIds ) . ')' ], __METHOD__ );
+ [ 'blob_id' => $blobIds ],
+ __METHOD__
+ );
foreach ( $res as $row ) {
unset( $xBlobIds[$row->blob_id]
);
}
@@ -410,7 +412,9 @@
$headerLength = strlen( self::CONCAT_HEADER );
$res = $extDb->select( $blobsTable,
[ 'blob_id', "LEFT(blob_text, $headerLength) AS
header" ],
- [ 'blob_id IN( ' . implode( ',', $blobIds ) .
')' ], __METHOD__ );
+ [ 'blob_id' => $blobIds ],
+ __METHOD__
+ );
foreach ( $res as $row ) {
if ( strcasecmp( $row->header,
self::CONCAT_HEADER ) ) {
$this->addError(
--
To view, visit https://gerrit.wikimedia.org/r/398205
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifca7bd6d0385dd470cddc483f4641eeb2832580c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Pppery <maprea...@olum.org>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
