[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ImagePage: Do not parse message 'imgmultipageprev'

2017-05-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/356037 )

Change subject: ImagePage: Do not parse message 'imgmultipageprev'
..


ImagePage: Do not parse message 'imgmultipageprev'

This message is used as alt text for an image thumbnail, and so it
can't contain HTML tags anyway. This matches the 'imgmultipagenext'
message now. (This inconsistency has been present ever since the
feature was introduced in 2006: 7f7e79022bfd421e49084b089e74c7a16b77bc03.)

Due to using OutputPage::parse() instead of Message::parse(), an
incorrect `` wrapper was also being added.

Bug: T166508
Change-Id: I092887cc91e2c800685d4e55177aed814bb3fce9
---
M includes/page/ImagePage.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/page/ImagePage.php b/includes/page/ImagePage.php
index f3c3ed8..6a751ac 100644
--- a/includes/page/ImagePage.php
+++ b/includes/page/ImagePage.php
@@ -434,7 +434,7 @@
$count = $this->displayImg->pageCount();
 
if ( $page > 1 ) {
-   $label = $out->parse( 
$this->getContext()->msg( 'imgmultipageprev' )->text(), false );
+   $label = 
$this->getContext()->msg( 'imgmultipageprev' )->text();
// on the client side, this 
link is generated in ajaxifyPageNavigation()
// in the 
mediawiki.page.image.pagination module
$link = Linker::linkKnown(

-- 
To view, visit https://gerrit.wikimedia.org/r/356037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I092887cc91e2c800685d4e55177aed814bb3fce9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ImagePage: Do not parse message 'imgmultipageprev'

2017-05-29 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/356037 )

Change subject: ImagePage: Do not parse message 'imgmultipageprev'
..

ImagePage: Do not parse message 'imgmultipageprev'

This message is used as alt text for an image thumbnail, and so it
can't contain HTML tags anyway. This matches the 'imgmultipagenext'
message now. (This inconsistency has been present ever since the
feature was introduced in 2006: 7f7e79022bfd421e49084b089e74c7a16b77bc03.)

Due to using OutputPage::parse() instead of Message::parse(), an
incorrect `` wrapper was also being added.

Bug: T166508
Change-Id: I092887cc91e2c800685d4e55177aed814bb3fce9
---
M includes/page/ImagePage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/37/356037/1

diff --git a/includes/page/ImagePage.php b/includes/page/ImagePage.php
index f3c3ed8..6a751ac 100644
--- a/includes/page/ImagePage.php
+++ b/includes/page/ImagePage.php
@@ -434,7 +434,7 @@
$count = $this->displayImg->pageCount();
 
if ( $page > 1 ) {
-   $label = $out->parse( 
$this->getContext()->msg( 'imgmultipageprev' )->text(), false );
+   $label = 
$this->getContext()->msg( 'imgmultipageprev' )->text();
// on the client side, this 
link is generated in ajaxifyPageNavigation()
// in the 
mediawiki.page.image.pagination module
$link = Linker::linkKnown(

-- 
To view, visit https://gerrit.wikimedia.org/r/356037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I092887cc91e2c800685d4e55177aed814bb3fce9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits