[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move MWCryptHash into libs/

2016-10-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Move MWCryptHash into libs/
..


Move MWCryptHash into libs/

Remove the single wfDebug() call that was making this class MW specific,
someone can log the return value of MWCryptHash::hashAlgo() if they'd
like to know the specific implementation being used.

Change-Id: Ibb7ead7594edab7861631046dd8316daab613401
---
M autoload.php
R includes/libs/MWCryptHash.php
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/autoload.php b/autoload.php
index 8d9a80f..5e81e83 100644
--- a/autoload.php
+++ b/autoload.php
@@ -771,7 +771,7 @@
'MWCallableUpdate' => __DIR__ . 
'/includes/deferred/MWCallableUpdate.php',
'MWContentSerializationException' => __DIR__ . 
'/includes/content/ContentHandler.php',
'MWCryptHKDF' => __DIR__ . '/includes/utils/MWCryptHKDF.php',
-   'MWCryptHash' => __DIR__ . '/includes/utils/MWCryptHash.php',
+   'MWCryptHash' => __DIR__ . '/includes/libs/MWCryptHash.php',
'MWCryptRand' => __DIR__ . '/includes/utils/MWCryptRand.php',
'MWDebug' => __DIR__ . '/includes/debug/MWDebug.php',
'MWDocGen' => __DIR__ . '/maintenance/mwdocgen.php',
diff --git a/includes/utils/MWCryptHash.php b/includes/libs/MWCryptHash.php
similarity index 97%
rename from includes/utils/MWCryptHash.php
rename to includes/libs/MWCryptHash.php
index 1117357..f9b7172 100644
--- a/includes/utils/MWCryptHash.php
+++ b/includes/libs/MWCryptHash.php
@@ -52,7 +52,6 @@
foreach ( $preference as $algorithm ) {
if ( in_array( $algorithm, $algos ) ) {
self::$algo = $algorithm;
-   wfDebug( __METHOD__ . ': Using the ' . 
self::$algo . " hash algorithm.\n" );
 
return self::$algo;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/313687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb7ead7594edab7861631046dd8316daab613401
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move MWCryptHash into libs/

2016-10-02 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/313687

Change subject: Move MWCryptHash into libs/
..

Move MWCryptHash into libs/

Remove the single wfDebug() call that was making this class MW specific,
someone can log the return value of MWCryptHash::hashAlgo() if they'd
like to know the specific implementation being used.

Change-Id: Ibb7ead7594edab7861631046dd8316daab613401
---
M autoload.php
R includes/libs/MWCryptHash.php
2 files changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/87/313687/1

diff --git a/autoload.php b/autoload.php
index 8d9a80f..5e81e83 100644
--- a/autoload.php
+++ b/autoload.php
@@ -771,7 +771,7 @@
'MWCallableUpdate' => __DIR__ . 
'/includes/deferred/MWCallableUpdate.php',
'MWContentSerializationException' => __DIR__ . 
'/includes/content/ContentHandler.php',
'MWCryptHKDF' => __DIR__ . '/includes/utils/MWCryptHKDF.php',
-   'MWCryptHash' => __DIR__ . '/includes/utils/MWCryptHash.php',
+   'MWCryptHash' => __DIR__ . '/includes/libs/MWCryptHash.php',
'MWCryptRand' => __DIR__ . '/includes/utils/MWCryptRand.php',
'MWDebug' => __DIR__ . '/includes/debug/MWDebug.php',
'MWDocGen' => __DIR__ . '/maintenance/mwdocgen.php',
diff --git a/includes/utils/MWCryptHash.php b/includes/libs/MWCryptHash.php
similarity index 97%
rename from includes/utils/MWCryptHash.php
rename to includes/libs/MWCryptHash.php
index 1117357..f9b7172 100644
--- a/includes/utils/MWCryptHash.php
+++ b/includes/libs/MWCryptHash.php
@@ -52,7 +52,6 @@
foreach ( $preference as $algorithm ) {
if ( in_array( $algorithm, $algos ) ) {
self::$algo = $algorithm;
-   wfDebug( __METHOD__ . ': Using the ' . 
self::$algo . " hash algorithm.\n" );
 
return self::$algo;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/313687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb7ead7594edab7861631046dd8316daab613401
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits