[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Only set memcache hash when saving messages to memcache

2016-10-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Only set memcache hash when saving messages to memcache
..


Only set memcache hash when saving messages to memcache

Shouldn't need to change the memcache hash unless we're changing the
memcache value.

Bug: T144952
Change-Id: I8e5cc29bfa0372f0071914e534e0b80cc4d34286
---
M includes/cache/MessageCache.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php
index f393acd..6834ac0 100644
--- a/includes/cache/MessageCache.php
+++ b/includes/cache/MessageCache.php
@@ -631,11 +631,11 @@
if ( $dest === 'all' ) {
$cacheKey = wfMemcKey( 'messages', $code );
$success = $this->mMemc->set( $cacheKey, $cache );
+   $this->setValidationHash( $code, $cache );
} else {
$success = true;
}
 
-   $this->setValidationHash( $code, $cache );
$this->saveToLocalCache( $code, $cache );
 
return $success;

-- 
To view, visit https://gerrit.wikimedia.org/r/315712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e5cc29bfa0372f0071914e534e0b80cc4d34286
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: RobLa 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Only set memcache hash when saving messages to memcache

2016-10-13 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315712

Change subject: Only set memcache hash when saving messages to memcache
..

Only set memcache hash when saving messages to memcache

Shouldn't need to change the memcache hash unless we're changing the
memcache value.

Bug: T144952
Change-Id: I8e5cc29bfa0372f0071914e534e0b80cc4d34286
---
M includes/cache/MessageCache.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/12/315712/1

diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php
index f393acd..6834ac0 100644
--- a/includes/cache/MessageCache.php
+++ b/includes/cache/MessageCache.php
@@ -631,11 +631,11 @@
if ( $dest === 'all' ) {
$cacheKey = wfMemcKey( 'messages', $code );
$success = $this->mMemc->set( $cacheKey, $cache );
+   $this->setValidationHash( $code, $cache );
} else {
$success = true;
}
 
-   $this->setValidationHash( $code, $cache );
$this->saveToLocalCache( $code, $cache );
 
return $success;

-- 
To view, visit https://gerrit.wikimedia.org/r/315712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e5cc29bfa0372f0071914e534e0b80cc4d34286
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits