[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Quote $default in PostgresUpdater::setDefault

2017-09-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376907 )

Change subject: Quote $default in PostgresUpdater::setDefault
..


Quote $default in PostgresUpdater::setDefault

Bug: T175439
Change-Id: Id5f5f4f34c7b9ff9af4b706e3e126ba8fda6a0d5
---
M includes/installer/PostgresUpdater.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/includes/installer/PostgresUpdater.php 
b/includes/installer/PostgresUpdater.php
index e5a5c94..07aeb13 100644
--- a/includes/installer/PostgresUpdater.php
+++ b/includes/installer/PostgresUpdater.php
@@ -783,7 +783,8 @@
$info = $this->db->fieldInfo( $table, $field );
if ( $info->defaultValue() !== $default ) {
$this->output( "Changing '$table.$field' default 
value\n" );
-   $this->db->query( "ALTER TABLE $table ALTER $field SET 
DEFAULT " . $default );
+   $this->db->query( "ALTER TABLE $table ALTER $field SET 
DEFAULT "
+   . $this->db->addQuotes( $default ) );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5f5f4f34c7b9ff9af4b706e3e126ba8fda6a0d5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Quote $default in PostgresUpdater::setDefault

2017-09-09 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376907 )

Change subject: Quote $default in PostgresUpdater::setDefault
..

Quote $default in PostgresUpdater::setDefault

Bug: T175439
Change-Id: Id5f5f4f34c7b9ff9af4b706e3e126ba8fda6a0d5
---
M includes/installer/PostgresUpdater.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/376907/1

diff --git a/includes/installer/PostgresUpdater.php 
b/includes/installer/PostgresUpdater.php
index e5a5c94..9199a71 100644
--- a/includes/installer/PostgresUpdater.php
+++ b/includes/installer/PostgresUpdater.php
@@ -783,7 +783,7 @@
$info = $this->db->fieldInfo( $table, $field );
if ( $info->defaultValue() !== $default ) {
$this->output( "Changing '$table.$field' default 
value\n" );
-   $this->db->query( "ALTER TABLE $table ALTER $field SET 
DEFAULT " . $default );
+   $this->db->query( "ALTER TABLE $table ALTER $field SET 
DEFAULT " . $this->db->addQuotes( $default ) );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5f5f4f34c7b9ff9af4b706e3e126ba8fda6a0d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits