[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RC Filters: combine user registration and experience level f...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365234 )

Change subject: RC Filters: combine user registration and experience level 
filters
..


RC Filters: combine user registration and experience level filters

Add 'registered' and 'unregistered' filters to
user experience group.

Keep minimal definitions of user registration to
support hideanons and hideliu for no-js and
users who are not using ERI filters.

Reword all user experience levels description according
to the phab task.

Bug: T165160
Change-Id: Ie6b1795d7cbdb1692f8eeb13db7afb89ea4e5bbc
---
M includes/specialpage/ChangesListSpecialPage.php
M languages/i18n/en.json
M languages/i18n/qqq.json
M tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
4 files changed, 193 insertions(+), 73 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specialpage/ChangesListSpecialPage.php 
b/includes/specialpage/ChangesListSpecialPage.php
index b85d272..645fbb2 100644
--- a/includes/specialpage/ChangesListSpecialPage.php
+++ b/includes/specialpage/ChangesListSpecialPage.php
@@ -86,8 +86,6 @@
'filters' => [
[
'name' => 'hideliu',
-   'label' => 
'rcfilters-filter-registered-label',
-   'description' => 
'rcfilters-filter-registered-description',
// rcshowhideliu-show, 
rcshowhideliu-hide,
// wlshowhideliu
'showHideSuffix' => 
'showhideliu',
@@ -97,16 +95,11 @@
) {
$conds[] = 'rc_user = 
0';
},
-   'cssClassSuffix' => 'liu',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   return 
$rc->getAttribute( 'rc_user' );
-   },
+   'isReplacedInStructuredUi' => 
true,
 
],
[
'name' => 'hideanons',
-   'label' => 
'rcfilters-filter-unregistered-label',
-   'description' => 
'rcfilters-filter-unregistered-description',
// rcshowhideanons-show, 
rcshowhideanons-hide,
// wlshowhideanons
'showHideSuffix' => 
'showhideanons',
@@ -116,10 +109,7 @@
) {
$conds[] = 'rc_user != 
0';
},
-   'cssClassSuffix' => 'anon',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   return 
!$rc->getAttribute( 'rc_user' );
-   },
+   'isReplacedInStructuredUi' => 
true,
]
],
],
@@ -128,9 +118,26 @@
'name' => 'userExpLevel',
'title' => 'rcfilters-filtergroup-userExpLevel',
'class' => 
ChangesListStringOptionsFilterGroup::class,
-   // Excludes unregistered users
-   'isFullCoverage' => false,
+   'isFullCoverage' => true,
'filters' => [
+   [
+   'name' => 'unregistered',
+   'label' => 
'rcfilters-filter-user-experience-level-unregistered-label',
+   'description' => 
'rcfilters-filter-user-experience-level-unregistered-description',
+   'cssClassSuffix' => 
'user-unregistered',
+   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
+   return 
!$rc->getAttribute( 'rc_user' );
+   }
+

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RC Filters: combine user registration and experience level f...

[Sbisson (Code Review)]

Sbisson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365234 )

Change subject: RC Filters: combine user registration and experience level 
filters
..

RC Filters: combine user registration and experience level filters

Add 'registered' and 'unregistered' filters to
user experience group.

Keep minimal definitions of user registration to
support hideanons and hideliu for no-js and
users who are not using ERI filters.

Reword all user exprience levels description according
to the phab task.

Bug: T165160
Change-Id: Ie6b1795d7cbdb1692f8eeb13db7afb89ea4e5bbc
---
M includes/specialpage/ChangesListSpecialPage.php
M languages/i18n/en.json
M languages/i18n/qqq.json
M tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
4 files changed, 180 insertions(+), 72 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/34/365234/1

diff --git a/includes/specialpage/ChangesListSpecialPage.php 
b/includes/specialpage/ChangesListSpecialPage.php
index 8c4cc11..fdea48d 100644
--- a/includes/specialpage/ChangesListSpecialPage.php
+++ b/includes/specialpage/ChangesListSpecialPage.php
@@ -85,8 +85,6 @@
'filters' => [
[
'name' => 'hideliu',
-   'label' => 
'rcfilters-filter-registered-label',
-   'description' => 
'rcfilters-filter-registered-description',
// rcshowhideliu-show, 
rcshowhideliu-hide,
// wlshowhideliu
'showHideSuffix' => 
'showhideliu',
@@ -96,16 +94,11 @@
) {
$conds[] = 'rc_user = 
0';
},
-   'cssClassSuffix' => 'liu',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   return 
$rc->getAttribute( 'rc_user' );
-   },
+   'isReplacedInStructuredUi' => 
true,
 
],
[
'name' => 'hideanons',
-   'label' => 
'rcfilters-filter-unregistered-label',
-   'description' => 
'rcfilters-filter-unregistered-description',
// rcshowhideanons-show, 
rcshowhideanons-hide,
// wlshowhideanons
'showHideSuffix' => 
'showhideanons',
@@ -115,10 +108,7 @@
) {
$conds[] = 'rc_user != 
0';
},
-   'cssClassSuffix' => 'anon',
-   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
-   return 
!$rc->getAttribute( 'rc_user' );
-   },
+   'isReplacedInStructuredUi' => 
true,
]
],
],
@@ -128,8 +118,26 @@
'title' => 'rcfilters-filtergroup-userExpLevel',
'class' => 
ChangesListStringOptionsFilterGroup::class,
// Excludes unregistered users
-   'isFullCoverage' => false,
+   'isFullCoverage' => true,
'filters' => [
+   [
+   'name' => 'unregistered',
+   'label' => 
'rcfilters-filter-user-experience-level-unregistered-label',
+   'description' => 
'rcfilters-filter-user-experience-level-unregistered-description',
+   'cssClassSuffix' => 
'user-unregistered',
+   'isRowApplicableCallable' => 
function ( $ctx, $rc ) {
+   return 
!$rc->getAttribute( 'rc_user' );
+   }
+   ],
+