[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Only build tag list when experimental views are e...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363969 )

Change subject: RCFilters: Only build tag list when experimental views are 
enabled
..


RCFilters: Only build tag list when experimental views are enabled

Follows-up 7725c755867ac1.

It's a waste otherwise, and buildChangeTagList() has perf issues.

Change-Id: Ifd7f81792fd7b5ee6e41ada756abbf0248f3eb36
---
M includes/specials/SpecialRecentchanges.php
1 file changed, 10 insertions(+), 5 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index 4f21586..2fe56f9 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -177,6 +177,9 @@
)
);
 
+   $experimentalStructuredChangeFilters =
+   $this->getConfig()->get( 
'StructuredChangeFiltersEnableExperimentalViews' );
+
$out->addJsConfigVars( 'wgStructuredChangeFilters', 
$jsData['groups'] );
$out->addJsConfigVars(
'wgStructuredChangeFiltersEnableSaving',
@@ -184,16 +187,18 @@
);
$out->addJsConfigVars(

'wgStructuredChangeFiltersEnableExperimentalViews',
-   $this->getConfig()->get( 
'StructuredChangeFiltersEnableExperimentalViews' )
+   $experimentalStructuredChangeFilters
);
$out->addJsConfigVars(
'wgStructuredChangeFiltersEnableLiveUpdate',
$this->getConfig()->get( 
'StructuredChangeFiltersEnableLiveUpdate' )
);
-   $out->addJsConfigVars(
-   'wgRCFiltersChangeTags',
-   $this->buildChangeTagList()
-   );
+   if ( $experimentalStructuredChangeFilters ) {
+   $out->addJsConfigVars(
+   'wgRCFiltersChangeTags',
+   $this->buildChangeTagList()
+   );
+   }
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd7f81792fd7b5ee6e41ada756abbf0248f3eb36
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Only build tag list when experimental views are e...

[Catrope (Code Review)]

Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363969 )

Change subject: RCFilters: Only build tag list when experimental views are 
enabled
..

RCFilters: Only build tag list when experimental views are enabled

It's a waste otherwise, and buildChangeTagList() has perf issues.

Change-Id: Ifd7f81792fd7b5ee6e41ada756abbf0248f3eb36
---
M includes/specials/SpecialRecentchanges.php
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/69/363969/1

diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index d856d4b..6e5b400 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -189,10 +189,12 @@

'wgStructuredChangeFiltersEnableExperimentalViews',

$wgStructuredChangeFiltersEnableExperimentalViews
);
-   $out->addJsConfigVars(
-   'wgRCFiltersChangeTags',
-   $this->buildChangeTagList()
-   );
+   if ( $wgStructuredChangeFiltersEnableExperimentalViews 
) {
+   $out->addJsConfigVars(
+   'wgRCFiltersChangeTags',
+   $this->buildChangeTagList()
+   );
+   }
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd7f81792fd7b5ee6e41ada756abbf0248f3eb36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits