[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove getSearchEngine() from DatabaseBase

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Remove getSearchEngine() from DatabaseBase
..


Remove getSearchEngine() from DatabaseBase

Change-Id: I1d5f43a90c50ab8cf5b6e58f290751c3aec73c4e
---
M includes/libs/rdbms/database/DatabaseBase.php
1 file changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/libs/rdbms/database/DatabaseBase.php 
b/includes/libs/rdbms/database/DatabaseBase.php
index e008705..71e5f93 100644
--- a/includes/libs/rdbms/database/DatabaseBase.php
+++ b/includes/libs/rdbms/database/DatabaseBase.php
@@ -29,14 +29,5 @@
  * @ingroup Database
  */
 abstract class DatabaseBase extends Database {
-   /**
-* Get search engine class. All subclasses of this need to implement 
this
-* if they wish to use searching.
-*
-* @return string
-* @deprecated since 1.27; use 
SearchEngineFactory::getSearchEngineClass()
-*/
-   public function getSearchEngine() {
-   return 'SearchEngineDummy';
-   }
+   // Backwards-compatibility alias for type-hints
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/312617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5f43a90c50ab8cf5b6e58f290751c3aec73c4e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove getSearchEngine() from DatabaseBase

[Aaron Schulz (Code Review)]

Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312617

Change subject: Remove getSearchEngine() from DatabaseBase
..

Remove getSearchEngine() from DatabaseBase

Change-Id: I1d5f43a90c50ab8cf5b6e58f290751c3aec73c4e
---
M includes/libs/rdbms/database/DatabaseBase.php
1 file changed, 1 insertion(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/17/312617/1

diff --git a/includes/libs/rdbms/database/DatabaseBase.php 
b/includes/libs/rdbms/database/DatabaseBase.php
index e008705..71e5f93 100644
--- a/includes/libs/rdbms/database/DatabaseBase.php
+++ b/includes/libs/rdbms/database/DatabaseBase.php
@@ -29,14 +29,5 @@
  * @ingroup Database
  */
 abstract class DatabaseBase extends Database {
-   /**
-* Get search engine class. All subclasses of this need to implement 
this
-* if they wish to use searching.
-*
-* @return string
-* @deprecated since 1.27; use 
SearchEngineFactory::getSearchEngineClass()
-*/
-   public function getSearchEngine() {
-   return 'SearchEngineDummy';
-   }
+   // Backwards-compatibility alias for type-hints
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/312617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d5f43a90c50ab8cf5b6e58f290751c3aec73c4e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits