[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove load array indexes from LoadBalancer errors

2017-04-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/349089 )

Change subject: Remove load array indexes from LoadBalancer errors
..


Remove load array indexes from LoadBalancer errors

This are not very useful and where not using SPI interpolation either.

Change-Id: Ia3a33da3a4593fbcba59b21f5b5028860752ce09
---
M includes/libs/rdbms/loadbalancer/LoadBalancer.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php 
b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 1202831..e2fbf72 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -269,11 +269,11 @@
$host = $this->getServerName( $i );
if ( $lag === false && !is_infinite( 
$maxServerLag ) ) {
$this->replLogger->error(
-   "Server {host} (#$i) is not 
replicating?", [ 'host' => $host ] );
+   "Server {host} is not 
replicating?", [ 'host' => $host ] );
unset( $loads[$i] );
} elseif ( $lag > $maxServerLag ) {
$this->replLogger->warning(
-   "Server {host} (#$i) has {lag} 
seconds of lag (>= {maxlag})",
+   "Server {host} has {lag} 
seconds of lag (>= {maxlag})",
[ 'host' => $host, 'lag' => 
$lag, 'maxlag' => $maxServerLag ]
);
unset( $loads[$i] );

-- 
To view, visit https://gerrit.wikimedia.org/r/349089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3a33da3a4593fbcba59b21f5b5028860752ce09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove load array indexes from LoadBalancer errors

2017-04-19 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349089 )

Change subject: Remove load array indexes from LoadBalancer errors
..

Remove load array indexes from LoadBalancer errors

This are not very useful and where not using SPI interpolation either.

Change-Id: Ia3a33da3a4593fbcba59b21f5b5028860752ce09
---
M includes/libs/rdbms/loadbalancer/LoadBalancer.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/89/349089/1

diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php 
b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 1202831..e2fbf72 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -269,11 +269,11 @@
$host = $this->getServerName( $i );
if ( $lag === false && !is_infinite( 
$maxServerLag ) ) {
$this->replLogger->error(
-   "Server {host} (#$i) is not 
replicating?", [ 'host' => $host ] );
+   "Server {host} is not 
replicating?", [ 'host' => $host ] );
unset( $loads[$i] );
} elseif ( $lag > $maxServerLag ) {
$this->replLogger->warning(
-   "Server {host} (#$i) has {lag} 
seconds of lag (>= {maxlag})",
+   "Server {host} has {lag} 
seconds of lag (>= {maxlag})",
[ 'host' => $host, 'lag' => 
$lag, 'maxlag' => $maxServerLag ]
);
unset( $loads[$i] );

-- 
To view, visit https://gerrit.wikimedia.org/r/349089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3a33da3a4593fbcba59b21f5b5028860752ce09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits