[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove old workaround for HHVM

2017-10-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383964 )

Change subject: Remove old workaround for HHVM
..


Remove old workaround for HHVM

The bug in question was fixed in HHVM 3.6.0, our minimum requirement is 3.6.5.

Change-Id: Id1d65cf438c7148064d747f09728ef4cb5f51b52
---
M maintenance/Maintenance.php
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php
index ecbbb85..4ad6e6e 100644
--- a/maintenance/Maintenance.php
+++ b/maintenance/Maintenance.php
@@ -1444,13 +1444,7 @@
}
 
if ( $isatty && function_exists( 'readline' ) ) {
-   $resp = readline( $prompt );
-   if ( $resp === null ) {
-   // Workaround for 
https://github.com/facebook/hhvm/issues/4776
-   return false;
-   } else {
-   return $resp;
-   }
+   return readline( $prompt );
} else {
if ( $isatty ) {
$st = self::readlineEmulation( $prompt );

-- 
To view, visit https://gerrit.wikimedia.org/r/383964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1d65cf438c7148064d747f09728ef4cb5f51b52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove old workaround for HHVM

2017-10-12 Thread MaxSem (Code Review) 
MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383964 )

Change subject: Remove old workaround for HHVM
..

Remove old workaround for HHVM

The bug in question was fixed in HHVM 3.6.0, our minimum requirement is 3.6.5.

Change-Id: Id1d65cf438c7148064d747f09728ef4cb5f51b52
---
M maintenance/Maintenance.php
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/64/383964/1

diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php
index ecbbb85..4ad6e6e 100644
--- a/maintenance/Maintenance.php
+++ b/maintenance/Maintenance.php
@@ -1444,13 +1444,7 @@
}
 
if ( $isatty && function_exists( 'readline' ) ) {
-   $resp = readline( $prompt );
-   if ( $resp === null ) {
-   // Workaround for 
https://github.com/facebook/hhvm/issues/4776
-   return false;
-   } else {
-   return $resp;
-   }
+   return readline( $prompt );
} else {
if ( $isatty ) {
$st = self::readlineEmulation( $prompt );

-- 
To view, visit https://gerrit.wikimedia.org/r/383964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1d65cf438c7148064d747f09728ef4cb5f51b52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits