jenkins-bot has submitted this change and it was merged. Change subject: Special:RC filters: hide page edits, new pages, log entries ......................................................................
Special:RC filters: hide page edits, new pages, log entries New RC filters for ERI project: hidepageedits hidenewpages hidelog Bug: T150060 Change-Id: I6fe852fb0f5386c3385ada5189ceaf0d9bbc979d --- M includes/specialpage/ChangesListSpecialPage.php M tests/phpunit/includes/specials/SpecialRecentchangesTest.php 2 files changed, 54 insertions(+), 0 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index 9e3e3df..c1c1685 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -150,6 +150,9 @@ if ( $config->get( 'RCWatchCategoryMembership' ) ) { $opts->add( 'hidecategorization', false ); } + $opts->add( 'hidepageedits', false ); + $opts->add( 'hidenewpages', false ); + $opts->add( 'hidelog', false ); $opts->add( 'namespace', '', FormOptions::INTNULL ); $opts->add( 'invert', false ); @@ -269,6 +272,15 @@ ) { $conds[] = 'rc_type != ' . $dbr->addQuotes( RC_CATEGORIZE ); } + if ( $opts['hidepageedits'] ) { + $conds[] = 'rc_type != ' . $dbr->addQuotes( RC_EDIT ); + } + if ( $opts['hidenewpages'] ) { + $conds[] = 'rc_type != ' . $dbr->addQuotes( RC_NEW ); + } + if ( $opts['hidelog'] ) { + $conds[] = 'rc_type != ' . $dbr->addQuotes( RC_LOG ); + } // Namespace filtering if ( $opts['namespace'] !== '' ) { diff --git a/tests/phpunit/includes/specials/SpecialRecentchangesTest.php b/tests/phpunit/includes/specials/SpecialRecentchangesTest.php index 6fb0d23..388e2fd 100644 --- a/tests/phpunit/includes/specials/SpecialRecentchangesTest.php +++ b/tests/phpunit/includes/specials/SpecialRecentchangesTest.php @@ -225,4 +225,46 @@ $user ); } + + public function testRcHidepageedits() { + $this->assertConditions( + [ # expected + 'rc_bot' => 0, + "rc_type != '6'", + "rc_type != '0'", + ], + [ + 'hidepageedits' => 1, + ], + "rc conditions: hidepageedits=1" + ); + } + + public function testRcHidenewpages() { + $this->assertConditions( + [ # expected + 'rc_bot' => 0, + "rc_type != '6'", + "rc_type != '1'", + ], + [ + 'hidenewpages' => 1, + ], + "rc conditions: hidenewpages=1" + ); + } + + public function testRcHidelog() { + $this->assertConditions( + [ # expected + 'rc_bot' => 0, + "rc_type != '6'", + "rc_type != '3'", + ], + [ + 'hidelog' => 1, + ], + "rc conditions: hidelog=1" + ); + } } -- To view, visit https://gerrit.wikimedia.org/r/321478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fe852fb0f5386c3385ada5189ceaf0d9bbc979d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Sbisson <sbis...@wikimedia.org> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Mooeypoo <mor...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits