[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use isDisabled() instead of isBlank() in getGrantName in Use...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Use isDisabled() instead of isBlank() in getGrantName in 
User.php
..


Use isDisabled() instead of isBlank() in getGrantName in User.php

Bug: T151956
Change-Id: Ic23c75b784c725f8f73eb1cf98d2bdb3763ab09d
---
M includes/user/User.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/user/User.php b/includes/user/User.php
index 82d8806..4950e27 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -5066,13 +5066,14 @@
/**
 * Get the description of a given right
 *
+* @since 1.29
 * @param string $right Right to query
 * @return string Localized description of the right
 */
public static function getRightDescription( $right ) {
$key = "right-$right";
$msg = wfMessage( $key );
-   return $msg->isBlank() ? $right : $msg->text();
+   return $msg->isDisabled() ? $right : $msg->text();
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/324337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic23c75b784c725f8f73eb1cf98d2bdb3763ab09d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MtDu 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use isDisabled() instead of isBlank() in getGrantName in Use...

[MtDu (Code Review)]

MtDu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324337

Change subject: Use isDisabled() instead of isBlank() in getGrantName in 
User.php
..

Use isDisabled() instead of isBlank() in getGrantName in User.php

Bug: T151956
Change-Id: Ic23c75b784c725f8f73eb1cf98d2bdb3763ab09d
---
M includes/user/User.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/37/324337/1

diff --git a/includes/user/User.php b/includes/user/User.php
index 82d8806..4950e27 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -5066,13 +5066,14 @@
/**
 * Get the description of a given right
 *
+* @since 1.29
 * @param string $right Right to query
 * @return string Localized description of the right
 */
public static function getRightDescription( $right ) {
$key = "right-$right";
$msg = wfMessage( $key );
-   return $msg->isBlank() ? $right : $msg->text();
+   return $msg->isDisabled() ? $right : $msg->text();
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/324337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic23c75b784c725f8f73eb1cf98d2bdb3763ab09d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MtDu 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits