[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use shell_exec instead of backtick

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363751 )

Change subject: Use shell_exec instead of backtick
..


Use shell_exec instead of backtick

They are exactly equivalent, but shell_exec is more readable.
We just imported a sniff to forbid backtick into mediawiki-codesniffer.

It's not deployed here yet, but this will facilitate it.

Change-Id: I4b58ed78e1792ff83e1bf99425f8f19123cfe911
---
M maintenance/mwdocgen.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/maintenance/mwdocgen.php b/maintenance/mwdocgen.php
index d005629..43041a43d 100644
--- a/maintenance/mwdocgen.php
+++ b/maintenance/mwdocgen.php
@@ -105,7 +105,7 @@
$this->excludePatterns[] = 'extensions';
}
 
-   $this->doDot = `which dot`;
+   $this->doDot = shell_exec( 'which dot' );
$this->doMan = $this->hasOption( 'generate-man' );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b58ed78e1792ff83e1bf99425f8f19123cfe911
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use shell_exec instead of backtick

[Mattflaschen (Code Review)]

Mattflaschen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363751 )

Change subject: Use shell_exec instead of backtick
..

Use shell_exec instead of backtick

They are exactly equivalent, but shell_exec is more readable.
We just imported a sniff to forbid backtick into mediawiki-codesniffer.

It's not deployed here yet, but this will facilitate it.

Change-Id: I4b58ed78e1792ff83e1bf99425f8f19123cfe911
---
M maintenance/mwdocgen.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/51/363751/1

diff --git a/maintenance/mwdocgen.php b/maintenance/mwdocgen.php
index d005629..43041a43d 100644
--- a/maintenance/mwdocgen.php
+++ b/maintenance/mwdocgen.php
@@ -105,7 +105,7 @@
$this->excludePatterns[] = 'extensions';
}
 
-   $this->doDot = `which dot`;
+   $this->doDot = shell_exec( 'which dot' );
$this->doMan = $this->hasOption( 'generate-man' );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b58ed78e1792ff83e1bf99425f8f19123cfe911
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits