[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Validate getExamplesMessages() query strings

2016-11-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Validate getExamplesMessages() query strings
..


Validate getExamplesMessages() query strings

Assert that they don't begin with 'api.php?'.

Change-Id: Idf5e8e08863a379a37a427a11936e5f9ce567396
Depends-On: I8a82eecefbb0ba327d8e8bc24ec535bcf40e6429
Depends-On: I476aad09655a2822381a2c61690b4b0ad423151e
---
M tests/phpunit/structure/ApiDocumentationTest.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/structure/ApiDocumentationTest.php 
b/tests/phpunit/structure/ApiDocumentationTest.php
index 2049e38..bc5a6bd 100644
--- a/tests/phpunit/structure/ApiDocumentationTest.php
+++ b/tests/phpunit/structure/ApiDocumentationTest.php
@@ -137,6 +137,8 @@
 
// Messages for examples.
foreach ( $module->getExamplesMessages() as $qs => $msg ) {
+   $this->assertStringStartsNotWith( 'api.php?', $qs,
+   "Query string must not begin with 'api.php?'" );
$this->checkMessage( $msg, "Example $qs" );
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/320524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf5e8e08863a379a37a427a11936e5f9ce567396
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Validate getExamplesMessages() query strings

2016-11-08 Thread Anomie (Code Review) 
Anomie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320524

Change subject: Validate getExamplesMessages() query strings
..

Validate getExamplesMessages() query strings

Assert that they don't begin with 'api.php?'.

Change-Id: Idf5e8e08863a379a37a427a11936e5f9ce567396
Depends-On: I8a82eecefbb0ba327d8e8bc24ec535bcf40e6429
Depends-On: I476aad09655a2822381a2c61690b4b0ad423151e
---
M tests/phpunit/structure/ApiDocumentationTest.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/24/320524/1

diff --git a/tests/phpunit/structure/ApiDocumentationTest.php 
b/tests/phpunit/structure/ApiDocumentationTest.php
index 2049e38..e979ce0 100644
--- a/tests/phpunit/structure/ApiDocumentationTest.php
+++ b/tests/phpunit/structure/ApiDocumentationTest.php
@@ -137,6 +137,8 @@
 
// Messages for examples.
foreach ( $module->getExamplesMessages() as $qs => $msg ) {
+   $this->assertFalse( (bool)preg_match( '/^api\.php\?/', 
$qs ),
+   "Query string must not begin with 'api.php?' 
for example $qs" );
$this->checkMessage( $msg, "Example $qs" );
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/320524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf5e8e08863a379a37a427a11936e5f9ce567396
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits