[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.19]: Fix ip_changes insert counting

2017-09-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/379415 )

Change subject: Fix ip_changes insert counting
..


Fix ip_changes insert counting

Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724
(cherry picked from commit 548e0da3278ae1cac8f5a5caed632e0f5eefb942)
---
M maintenance/populateIpChanges.php
1 file changed, 4 insertions(+), 7 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/populateIpChanges.php 
b/maintenance/populateIpChanges.php
index 2b2a2b4..40a596c 100644
--- a/maintenance/populateIpChanges.php
+++ b/maintenance/populateIpChanges.php
@@ -110,14 +110,11 @@
}
}
 
-   $dbw->insert(
-   'ip_changes',
-   $insertRows,
-   __METHOD__,
-   'IGNORE'
-   );
+   if ( $insertRows ) {
+   $dbw->insert( 'ip_changes', $insertRows, 
__METHOD__, 'IGNORE' );
 
-   $inserted += $dbw->affectedRows();
+   $inserted += $dbw->affectedRows();
+   }
 
$lbFactory->waitForReplication();
usleep( $throttle * 1000 );

-- 
To view, visit https://gerrit.wikimedia.org/r/379415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.19
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.19]: Fix ip_changes insert counting

2017-09-20 Thread MaxSem (Code Review) 
MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379415 )

Change subject: Fix ip_changes insert counting
..

Fix ip_changes insert counting

Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724
(cherry picked from commit 548e0da3278ae1cac8f5a5caed632e0f5eefb942)
---
M maintenance/populateIpChanges.php
1 file changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/15/379415/1

diff --git a/maintenance/populateIpChanges.php 
b/maintenance/populateIpChanges.php
index 2b2a2b4..40a596c 100644
--- a/maintenance/populateIpChanges.php
+++ b/maintenance/populateIpChanges.php
@@ -110,14 +110,11 @@
}
}
 
-   $dbw->insert(
-   'ip_changes',
-   $insertRows,
-   __METHOD__,
-   'IGNORE'
-   );
+   if ( $insertRows ) {
+   $dbw->insert( 'ip_changes', $insertRows, 
__METHOD__, 'IGNORE' );
 
-   $inserted += $dbw->affectedRows();
+   $inserted += $dbw->affectedRows();
+   }
 
$lbFactory->waitForReplication();
usleep( $throttle * 1000 );

-- 
To view, visit https://gerrit.wikimedia.org/r/379415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.19
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits