[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.1]: Revert "Add logging for Unicode check failures in EditPage"

2017-09-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/381143 )

Change subject: Revert "Add logging for Unicode check failures in EditPage"
..


Revert "Add logging for Unicode check failures in EditPage"

This reverts commit 454ae53a7991b1edd9b10f2ff30bb1d5e319e256.

Change-Id: I1d6ced4f365771412163199ffc90ee3b89cad43c
---
M includes/EditPage.php
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/EditPage.php b/includes/EditPage.php
index d742298..f49157f 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -918,7 +918,7 @@
}
}
 
-   $this->unicodeCheck = $request->getText( 
'wpUnicodeCheck', '' );
+   $this->unicodeCheck = $request->getText( 
'wpUnicodeCheck' );
 
$this->summary = $request->getText( 'wpSummary' );
 
@@ -1788,10 +1788,6 @@
}
 
if ( $this->unicodeCheck !== self::UNICODE_CHECK ) {
-   wfDebugLog( 'AdHocDebug', "Unicode check failed: 
value={$this->unicodeCheck}, expected "
-   . self::UNICODE_CHECK
-   . " UA: 
{$this->getContext()->getRequest()->getHeader( 'User-Agent' )}"
-   );
$status->fatal( 'unicode-support-fail' );
$status->value = self::AS_UNICODE_NOT_SUPPORTED;
return $status;

-- 
To view, visit https://gerrit.wikimedia.org/r/381143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d6ced4f365771412163199ffc90ee3b89cad43c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.1
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.1]: Revert "Add logging for Unicode check failures in EditPage"

2017-09-27 Thread MaxSem (Code Review) 
Hello jenkins-bot, Tpt, Jackmcbarn,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/381143

to review the following change.


Change subject: Revert "Add logging for Unicode check failures in EditPage"
..

Revert "Add logging for Unicode check failures in EditPage"

This reverts commit 454ae53a7991b1edd9b10f2ff30bb1d5e319e256.

Change-Id: I1d6ced4f365771412163199ffc90ee3b89cad43c
---
M includes/EditPage.php
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/43/381143/1

diff --git a/includes/EditPage.php b/includes/EditPage.php
index d742298..f49157f 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -918,7 +918,7 @@
}
}
 
-   $this->unicodeCheck = $request->getText( 
'wpUnicodeCheck', '' );
+   $this->unicodeCheck = $request->getText( 
'wpUnicodeCheck' );
 
$this->summary = $request->getText( 'wpSummary' );
 
@@ -1788,10 +1788,6 @@
}
 
if ( $this->unicodeCheck !== self::UNICODE_CHECK ) {
-   wfDebugLog( 'AdHocDebug', "Unicode check failed: 
value={$this->unicodeCheck}, expected "
-   . self::UNICODE_CHECK
-   . " UA: 
{$this->getContext()->getRequest()->getHeader( 'User-Agent' )}"
-   );
$status->fatal( 'unicode-support-fail' );
$status->value = self::AS_UNICODE_NOT_SUPPORTED;
return $status;

-- 
To view, visit https://gerrit.wikimedia.org/r/381143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d6ced4f365771412163199ffc90ee3b89cad43c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.1
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits