[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.10]: HTMLMultiSelectField: Allow formatting in section headings i...

2017-11-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394339 )

Change subject: HTMLMultiSelectField: Allow formatting in section headings in 
OOUI mode
..


HTMLMultiSelectField: Allow formatting in section headings in OOUI mode

Follow-up to 5a113417e5af9d0d0dbed63429649a9780784d45.
It is allowed in non-OOUI modes.

Bug: T181698
Change-Id: Ib2ebcd1a92f1b02a528787fe3fd1f5452b9808c4
(cherry picked from commit f75232305410689a54c86fe327a40586eb459239)
---
M includes/htmlform/fields/HTMLMultiSelectField.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php 
b/includes/htmlform/fields/HTMLMultiSelectField.php
index 238b2b4..09bacad 100644
--- a/includes/htmlform/fields/HTMLMultiSelectField.php
+++ b/includes/htmlform/fields/HTMLMultiSelectField.php
@@ -192,7 +192,7 @@
if ( $sectionLabel ) {
$out[] = new OOUI\FieldsetLayout( [
'items' => [ $widget ],
-   'label' => $sectionLabel,
+   'label' => new OOUI\HtmlSnippet( 
$sectionLabel ),
] );
} else {
$out[] = $widget;

-- 
To view, visit https://gerrit.wikimedia.org/r/394339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ebcd1a92f1b02a528787fe3fd1f5452b9808c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.10]: HTMLMultiSelectField: Allow formatting in section headings i...

2017-11-30 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394339 )

Change subject: HTMLMultiSelectField: Allow formatting in section headings in 
OOUI mode
..

HTMLMultiSelectField: Allow formatting in section headings in OOUI mode

Follow-up to 5a113417e5af9d0d0dbed63429649a9780784d45.
It is allowed in non-OOUI modes.

Bug: T181698
Change-Id: Ib2ebcd1a92f1b02a528787fe3fd1f5452b9808c4
(cherry picked from commit f75232305410689a54c86fe327a40586eb459239)
---
M includes/htmlform/fields/HTMLMultiSelectField.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/39/394339/1

diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php 
b/includes/htmlform/fields/HTMLMultiSelectField.php
index 238b2b4..09bacad 100644
--- a/includes/htmlform/fields/HTMLMultiSelectField.php
+++ b/includes/htmlform/fields/HTMLMultiSelectField.php
@@ -192,7 +192,7 @@
if ( $sectionLabel ) {
$out[] = new OOUI\FieldsetLayout( [
'items' => [ $widget ],
-   'label' => $sectionLabel,
+   'label' => new OOUI\HtmlSnippet( 
$sectionLabel ),
] );
} else {
$out[] = $widget;

-- 
To view, visit https://gerrit.wikimedia.org/r/394339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2ebcd1a92f1b02a528787fe3fd1f5452b9808c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits