[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.17]: EditPage: Update Save/Publish button flag from 'constructive...
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404733 ) Change subject: EditPage: Update Save/Publish button flag from 'constructive' to 'progressive' .. EditPage: Update Save/Publish button flag from 'constructive' to 'progressive' OOUI 'constructive' flag was removed in OOUI v0.25.0. Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58 (cherry picked from commit 656a2efcc2f4495b09a5d34b8980398690767db4) --- M includes/EditPage.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Niharika29: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/EditPage.php b/includes/EditPage.php index a41e6d9..62307b6 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -4405,7 +4405,7 @@ 'inputId' => 'wpSave', // Support: IE 6 – Use , otherwise it can't distinguish which button was clicked 'useInputTag' => true, - 'flags' => [ 'constructive', 'primary' ], + 'flags' => [ 'progressive', 'primary' ], 'label' => $buttonLabel, 'infusable' => true, 'type' => 'submit', -- To view, visit https://gerrit.wikimedia.org/r/404733 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.31.0-wmf.17 Gerrit-Owner: Jforrester Gerrit-Reviewer: Bartosz Dziewoński Gerrit-Reviewer: Jackmcbarn Gerrit-Reviewer: Jforrester Gerrit-Reviewer: Niharika29 Gerrit-Reviewer: Tpt Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.17]: EditPage: Update Save/Publish button flag from 'constructive...
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404733 ) Change subject: EditPage: Update Save/Publish button flag from 'constructive' to 'progressive' .. EditPage: Update Save/Publish button flag from 'constructive' to 'progressive' OOUI 'constructive' flag was removed in OOUI v0.25.0. Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58 (cherry picked from commit 656a2efcc2f4495b09a5d34b8980398690767db4) --- M includes/EditPage.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/33/404733/1 diff --git a/includes/EditPage.php b/includes/EditPage.php index a41e6d9..62307b6 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -4405,7 +4405,7 @@ 'inputId' => 'wpSave', // Support: IE 6 – Use , otherwise it can't distinguish which button was clicked 'useInputTag' => true, - 'flags' => [ 'constructive', 'primary' ], + 'flags' => [ 'progressive', 'primary' ], 'label' => $buttonLabel, 'infusable' => true, 'type' => 'submit', -- To view, visit https://gerrit.wikimedia.org/r/404733 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.31.0-wmf.17 Gerrit-Owner: Jforrester Gerrit-Reviewer: Bartosz Dziewoński ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits