[MediaWiki-commits] [Gerrit] mediawiki/vagrant[jessie-migration]: Remove phantomjs package from cirrussearch role

2017-03-02 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/340671 )

Change subject: Remove phantomjs package from cirrussearch role
..


Remove phantomjs package from cirrussearch role

This was previously used to allow runnign the browser tests inside
vagrant in a semi-performant way. Unfortunately this is no longer
available with jessie. This isn't strictly required, so rather than
finding an appropriate debian-equivilant ppa remove the requirement.

Change-Id: I219fff00e71d798848f2b4177d375954572e
---
M puppet/modules/role/manifests/cirrussearch.pp
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/role/manifests/cirrussearch.pp 
b/puppet/modules/role/manifests/cirrussearch.pp
index c008e90..1617e1c 100644
--- a/puppet/modules/role/manifests/cirrussearch.pp
+++ b/puppet/modules/role/manifests/cirrussearch.pp
@@ -17,11 +17,6 @@
 # necessary for CirrusSearch.php.erb to point to service root dir
 require ::service
 
-# By default Vagrant sets up firefox as the global browsertest
-# runner, we want to ensure phantomjs is available for running the
-# cirrussearch tests in a headless and parallelized manner.
-require_package('phantomjs')
-
 # Elasticsearch plugins
 ## Analysis
 elasticsearch::plugin { 'analysis-icu':

-- 
To view, visit https://gerrit.wikimedia.org/r/340671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I219fff00e71d798848f2b4177d375954572e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: jessie-migration
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Dduvall 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[jessie-migration]: Remove phantomjs package from cirrussearch role

2017-03-01 Thread EBernhardson (Code Review) 
EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/340671 )

Change subject: Remove phantomjs package from cirrussearch role
..

Remove phantomjs package from cirrussearch role

This was previously used to allow runnign the browser tests inside
vagrant in a semi-performant way. Unfortunately this is no longer
available with jessie. This isn't strictly required, so rather than
finding an appropriate debian-equivilant ppa remove the requirement.

Change-Id: I219fff00e71d798848f2b4177d375954572e
---
M puppet/modules/role/manifests/cirrussearch.pp
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/71/340671/1

diff --git a/puppet/modules/role/manifests/cirrussearch.pp 
b/puppet/modules/role/manifests/cirrussearch.pp
index c008e90..1617e1c 100644
--- a/puppet/modules/role/manifests/cirrussearch.pp
+++ b/puppet/modules/role/manifests/cirrussearch.pp
@@ -17,11 +17,6 @@
 # necessary for CirrusSearch.php.erb to point to service root dir
 require ::service
 
-# By default Vagrant sets up firefox as the global browsertest
-# runner, we want to ensure phantomjs is available for running the
-# cirrussearch tests in a headless and parallelized manner.
-require_package('phantomjs')
-
 # Elasticsearch plugins
 ## Analysis
 elasticsearch::plugin { 'analysis-icu':

-- 
To view, visit https://gerrit.wikimedia.org/r/340671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I219fff00e71d798848f2b4177d375954572e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: jessie-migration
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits