[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Convert Special:AbuseFilter/import to OOjs

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372055 )

Change subject: Convert Special:AbuseFilter/import to OOjs 
..


Convert Special:AbuseFilter/import to OOjs 

Based on https://gerrit.wikimedia.org/r/#/c/370150/
Bug: T132284

Change-Id: Iab2a24926c6b547e34f516149ff94953fb0da634
---
M includes/Views/AbuseFilterViewImport.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Huji: Looks good to me, but someone else must approve
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Views/AbuseFilterViewImport.php 
b/includes/Views/AbuseFilterViewImport.php
index 9186451..6bd4c26 100644
--- a/includes/Views/AbuseFilterViewImport.php
+++ b/includes/Views/AbuseFilterViewImport.php
@@ -9,14 +9,14 @@
}
$url = SpecialPage::getTitleFor( 'AbuseFilter', 'new' 
)->getFullURL();
 
+   $out->addWikiMsg( 'abusefilter-import-intro' );
+
$formDescriptor = [
'ImportText' => [
'type' => 'textarea',
-   'cols' => 200,
]
];
-   $htmlForm = new HTMLForm( $formDescriptor, $this->getContext() 
);
-   $htmlForm->setHeaderText( $this->msg( 
'abusefilter-import-intro' ) )
+   $htmlform = HTMLForm::factory( 'ooui', $formDescriptor, 
$this->getContext() )
->setSubmitTextMsg( 'abusefilter-import-submit' )
->setAction( $url )
->show();

-- 
To view, visit https://gerrit.wikimedia.org/r/372055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab2a24926c6b547e34f516149ff94953fb0da634
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Rendann 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Glaisher 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Convert Special:AbuseFilter/import to OOjs

[Rendann (Code Review)]

Rendann has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372055 )

Change subject: Convert Special:AbuseFilter/import to OOjs 
..

Convert Special:AbuseFilter/import to OOjs 

Based on https://gerrit.wikimedia.org/r/#/c/370150/
Bug: T132284

Change-Id: Iab2a24926c6b547e34f516149ff94953fb0da634
---
M includes/Views/AbuseFilterViewImport.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/55/372055/2

diff --git a/includes/Views/AbuseFilterViewImport.php 
b/includes/Views/AbuseFilterViewImport.php
index 9186451..6bd4c26 100644
--- a/includes/Views/AbuseFilterViewImport.php
+++ b/includes/Views/AbuseFilterViewImport.php
@@ -9,14 +9,14 @@
}
$url = SpecialPage::getTitleFor( 'AbuseFilter', 'new' 
)->getFullURL();
 
+   $out->addWikiMsg( 'abusefilter-import-intro' );
+
$formDescriptor = [
'ImportText' => [
'type' => 'textarea',
-   'cols' => 200,
]
];
-   $htmlForm = new HTMLForm( $formDescriptor, $this->getContext() 
);
-   $htmlForm->setHeaderText( $this->msg( 
'abusefilter-import-intro' ) )
+   $htmlform = HTMLForm::factory( 'ooui', $formDescriptor, 
$this->getContext() )
->setSubmitTextMsg( 'abusefilter-import-submit' )
->setAction( $url )
->show();

-- 
To view, visit https://gerrit.wikimedia.org/r/372055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab2a24926c6b547e34f516149ff94953fb0da634
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Rendann 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Convert Special:AbuseFilter/import to OOjs

[Rendann (Code Review)]

Rendann has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370150 )

Change subject: Convert Special:AbuseFilter/import to OOjs
..

Convert Special:AbuseFilter/import to OOjs

Bug: T132284
Change-Id: I37ec7b7408bda89c14d14a6f56fa90de4cc756f3
---
M Views/AbuseFilterViewImport.php
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/50/370150/2

diff --git a/Views/AbuseFilterViewImport.php b/Views/AbuseFilterViewImport.php
index 9186451..686c48c 100644
--- a/Views/AbuseFilterViewImport.php
+++ b/Views/AbuseFilterViewImport.php
@@ -9,16 +9,17 @@
}
$url = SpecialPage::getTitleFor( 'AbuseFilter', 'new' 
)->getFullURL();
 
+   $out->addWikiMsg( 'abusefilter-import-intro' );
+
$formDescriptor = [
'ImportText' => [
'type' => 'textarea',
-   'cols' => 200,
]
];
-   $htmlForm = new HTMLForm( $formDescriptor, $this->getContext() 
);
-   $htmlForm->setHeaderText( $this->msg( 
'abusefilter-import-intro' ) )
+   $htmlform = HTMLForm::factory( 'ooui', $formDescriptor, 
$this->getContext() )
->setSubmitTextMsg( 'abusefilter-import-submit' )
->setAction( $url )
-   ->show();
+   ->prepareForm()
+   ->displayForm( false );
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/370150
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37ec7b7408bda89c14d14a6f56fa90de4cc756f3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Rendann 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits