Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395669 )

Change subject: Enable Babel on mobile
......................................................................

Enable Babel on mobile

Changes:
* Turn on styles for mobile target
* Restrict floating rules to tablet. Enforce them with !important
to override table defaults

Bug: T178782
Change-Id: I9902359276894b6e94d9794247f5bde02983abd7
---
M extension.json
R resources/ext.babel.less
2 files changed, 19 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Babel 
refs/changes/69/395669/1

diff --git a/extension.json b/extension.json
index b82550c..53b36ee 100644
--- a/extension.json
+++ b/extension.json
@@ -38,8 +38,9 @@
        },
        "ResourceModules": {
                "ext.babel": {
+                       "targets": [ "desktop", "mobile" ],
                        "position": "top",
-                       "styles": "resources/ext.babel.css"
+                       "styles": "resources/ext.babel.less"
                }
        },
        "ResourceFileModulePaths": {
diff --git a/resources/ext.babel.css b/resources/ext.babel.less
similarity index 83%
rename from resources/ext.babel.css
rename to resources/ext.babel.less
index 87f0d2f..26b2f14 100644
--- a/resources/ext.babel.css
+++ b/resources/ext.babel.less
@@ -21,18 +21,6 @@
        border-spacing: 0;
 }
 
-/* @noflip */
-.mw-content-ltr .mw-babel-wrapper {
-       float: right;
-       clear: right;
-}
-
-/* @noflip */
-.mw-content-rtl .mw-babel-wrapper {
-       float: left;
-       clear: left;
-}
-
 /* Babel box layout */
 /* @noflip */
 .mw-babel-box {
@@ -168,3 +156,20 @@
        font-weight: normal;
        font-size: 85%;
 }
+
+@media all and ( min-width: @deviceWidthTablet ) {
+       /* @noflip */
+       .mw-content-ltr .mw-babel-wrapper {
+               // !important is necessary for skins like Minerva which try to 
avoid floating tables
+               float: right !important;
+               clear: right;
+       }
+
+       /* @noflip */
+       .mw-content-rtl .mw-babel-wrapper {
+               // !important is necessary for skins like Minerva which try to 
avoid floating tables
+               float: left !important;
+               clear: left;
+       }
+}
+

-- 
To view, visit https://gerrit.wikimedia.org/r/395669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9902359276894b6e94d9794247f5bde02983abd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Babel
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to