[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Added delimiter for list of "attached templates"

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/401004 )

Change subject: Added delimiter for list of "attached templates"
..


Added delimiter for list of "attached templates"

Change-Id: I843cdb463d03b70ba877494648d876e6fafb5e17
---
M specials/CargoTables.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/CargoTables.php b/specials/CargoTables.php
index f05914f..28836b4 100644
--- a/specials/CargoTables.php
+++ b/specials/CargoTables.php
@@ -318,7 +318,7 @@
$templateLinks[] = 
CargoUtils::makeLink( $linkRenderer, $templateTitle );
}
$declaringTemplatesText = $this->msg(
-   'cargo-cargotables-declaredby', 
implode( $templateLinks ) )->text();
+   'cargo-cargotables-declaredby', 
implode( ', ', $templateLinks ) )->text();
}
 
// "Attached by" text
@@ -337,7 +337,7 @@
$templateLinks[] = 
CargoUtils::makeLink( $linkRenderer, $templateTitle );
}
$attachingTemplatesText = $this->msg(
-   'cargo-cargotables-attachedby', 
implode( $templateLinks ) )->text();
+   'cargo-cargotables-attachedby', 
implode( ', ', $templateLinks ) )->text();
}
 
$tableText = "$tableName ($actionLinks) - $numRowsText 
($declaringTemplatesText";

-- 
To view, visit https://gerrit.wikimedia.org/r/401004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I843cdb463d03b70ba877494648d876e6fafb5e17
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Added delimiter for list of "attached templates"

[Yaron Koren (Code Review)]

Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401004 )

Change subject: Added delimiter for list of "attached templates"
..

Added delimiter for list of "attached templates"

Change-Id: I843cdb463d03b70ba877494648d876e6fafb5e17
---
M specials/CargoTables.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/04/401004/2

diff --git a/specials/CargoTables.php b/specials/CargoTables.php
index f05914f..28836b4 100644
--- a/specials/CargoTables.php
+++ b/specials/CargoTables.php
@@ -318,7 +318,7 @@
$templateLinks[] = 
CargoUtils::makeLink( $linkRenderer, $templateTitle );
}
$declaringTemplatesText = $this->msg(
-   'cargo-cargotables-declaredby', 
implode( $templateLinks ) )->text();
+   'cargo-cargotables-declaredby', 
implode( ', ', $templateLinks ) )->text();
}
 
// "Attached by" text
@@ -337,7 +337,7 @@
$templateLinks[] = 
CargoUtils::makeLink( $linkRenderer, $templateTitle );
}
$attachingTemplatesText = $this->msg(
-   'cargo-cargotables-attachedby', 
implode( $templateLinks ) )->text();
+   'cargo-cargotables-attachedby', 
implode( ', ', $templateLinks ) )->text();
}
 
$tableText = "$tableName ($actionLinks) - $numRowsText 
($declaringTemplatesText";

-- 
To view, visit https://gerrit.wikimedia.org/r/401004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I843cdb463d03b70ba877494648d876e6fafb5e17
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits