[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Changed list display delimiter from "middot" to "bullet"

2018-01-04 Thread Yaron Koren (Code Review) 
Yaron Koren has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402144 )

Change subject: Changed list display delimiter from "middot" to "bullet"
..


Changed list display delimiter from "middot" to "bullet"

Also added CSS class for it.

Change-Id: I7ed08996f51c04277fa69dedca0f53d8c6f7d975
---
M includes/CargoQueryDisplayer.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/CargoQueryDisplayer.php b/includes/CargoQueryDisplayer.php
index b5e384d..c509033 100644
--- a/includes/CargoQueryDisplayer.php
+++ b/includes/CargoQueryDisplayer.php
@@ -113,7 +113,7 @@
continue;
}
if ( $i > 0 ) {
-   // Use a "middle dot" as
+   // Use a bullet point as
// the list delimiter -
// it's better than 
using
// a comma, or the
@@ -122,7 +122,7 @@
// consistent and makes
// it clearer whether
// list parsing worked.
-   $text .= "  ";
+   $text .= '  ';
}
$text .= 
self::formatFieldValue( $fieldValue, $fieldType, $fieldDescription, 
$this->mParser );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/402144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ed08996f51c04277fa69dedca0f53d8c6f7d975
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Changed list display delimiter from "middot" to "bullet"

2018-01-04 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402144 )

Change subject: Changed list display delimiter from "middot" to "bullet"
..

Changed list display delimiter from "middot" to "bullet"

Also added CSS class for it.

Change-Id: I7ed08996f51c04277fa69dedca0f53d8c6f7d975
---
M includes/CargoQueryDisplayer.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/44/402144/2

diff --git a/includes/CargoQueryDisplayer.php b/includes/CargoQueryDisplayer.php
index b5e384d..c509033 100644
--- a/includes/CargoQueryDisplayer.php
+++ b/includes/CargoQueryDisplayer.php
@@ -113,7 +113,7 @@
continue;
}
if ( $i > 0 ) {
-   // Use a "middle dot" as
+   // Use a bullet point as
// the list delimiter -
// it's better than 
using
// a comma, or the
@@ -122,7 +122,7 @@
// consistent and makes
// it clearer whether
// list parsing worked.
-   $text .= "  ";
+   $text .= '  ';
}
$text .= 
self::formatFieldValue( $fieldValue, $fieldType, $fieldDescription, 
$this->mParser );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/402144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ed08996f51c04277fa69dedca0f53d8c6f7d975
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits