[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix for "group by" and "having" in query API

2017-12-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/400984 )

Change subject: Fix for "group by" and "having" in query API
..


Fix for "group by" and "having" in query API

Change-Id: Ibfbfdc13f0b095173bed17f1a3f28846d3418ae8
---
M api/CargoQueryAPI.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/api/CargoQueryAPI.php b/api/CargoQueryAPI.php
index 70afdb8..6be5dc5 100644
--- a/api/CargoQueryAPI.php
+++ b/api/CargoQueryAPI.php
@@ -28,7 +28,7 @@
}
 
$sqlQuery = CargoSQLQuery::newFromValues( $tablesStr, 
$fieldsStr, $whereStr, $joinOnStr,
-   $havingStr, $groupByStr, $orderByStr, $limitStr 
);
+   $groupByStr, $havingStr, $orderByStr, $limitStr 
);
try {
$queryResults = $sqlQuery->run();
} catch ( Exception $e ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/400984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfbfdc13f0b095173bed17f1a3f28846d3418ae8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix for "group by" and "having" in query API

2017-12-29 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400984 )

Change subject: Fix for "group by" and "having" in query API
..

Fix for "group by" and "having" in query API

Change-Id: Ibfbfdc13f0b095173bed17f1a3f28846d3418ae8
---
M api/CargoQueryAPI.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/84/400984/2

diff --git a/api/CargoQueryAPI.php b/api/CargoQueryAPI.php
index 70afdb8..6be5dc5 100644
--- a/api/CargoQueryAPI.php
+++ b/api/CargoQueryAPI.php
@@ -28,7 +28,7 @@
}
 
$sqlQuery = CargoSQLQuery::newFromValues( $tablesStr, 
$fieldsStr, $whereStr, $joinOnStr,
-   $havingStr, $groupByStr, $orderByStr, $limitStr 
);
+   $groupByStr, $havingStr, $orderByStr, $limitStr 
);
try {
$queryResults = $sqlQuery->run();
} catch ( Exception $e ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/400984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfbfdc13f0b095173bed17f1a3f28846d3418ae8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits