[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Moved "Hide" link for minimized text to beginning of text

2017-12-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395828 )

Change subject: Moved "Hide" link for minimized text to beginning of text
..


Moved "Hide" link for minimized text to beginning of text

Change-Id: Ic0a9e0fc73de129f6af8f8548257901051951f5a
---
M libs/Cargo.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/libs/Cargo.js b/libs/Cargo.js
index fce9838..022f361 100644
--- a/libs/Cargo.js
+++ b/libs/Cargo.js
@@ -13,11 +13,11 @@
 
 $('span.cargoMinimizedText')
.hide()
-   .parent().append('' + showText + '');
+   .parent().prepend('' + showText + ' ');
 
 $('a.cargoToggle').click( function() {
if ( $(this).text() == showText ) {
-   $(this).siblings('.cargoMinimizedText').show(400);
+   
$(this).siblings('.cargoMinimizedText').show(400).css('display', 'inline');
$(this).text(hideText);
} else {
$(this).siblings('.cargoMinimizedText').hide(400);

-- 
To view, visit https://gerrit.wikimedia.org/r/395828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0a9e0fc73de129f6af8f8548257901051951f5a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Moved "Hide" link for minimized text to beginning of text

2017-12-06 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395828 )

Change subject: Moved "Hide" link for minimized text to beginning of text
..

Moved "Hide" link for minimized text to beginning of text

Change-Id: Ic0a9e0fc73de129f6af8f8548257901051951f5a
---
M libs/Cargo.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/28/395828/2

diff --git a/libs/Cargo.js b/libs/Cargo.js
index fce9838..022f361 100644
--- a/libs/Cargo.js
+++ b/libs/Cargo.js
@@ -13,11 +13,11 @@
 
 $('span.cargoMinimizedText')
.hide()
-   .parent().append('' + showText + '');
+   .parent().prepend('' + showText + ' ');
 
 $('a.cargoToggle').click( function() {
if ( $(this).text() == showText ) {
-   $(this).siblings('.cargoMinimizedText').show(400);
+   
$(this).siblings('.cargoMinimizedText').show(400).css('display', 'inline');
$(this).text(hideText);
} else {
$(this).siblings('.cargoMinimizedText').hide(400);

-- 
To view, visit https://gerrit.wikimedia.org/r/395828
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0a9e0fc73de129f6af8f8548257901051951f5a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits