[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Check wfReadOnly() for rememberme preference callback

2017-04-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348943 )

Change subject: Check wfReadOnly() for rememberme preference callback
..


Check wfReadOnly() for rememberme preference callback

Change-Id: I378049213b348ab150ea66449d182e1497e4d9cb
---
M includes/specials/SpecialCentralAutoLogin.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialCentralAutoLogin.php 
b/includes/specials/SpecialCentralAutoLogin.php
index 122a728..57ff39e 100644
--- a/includes/specials/SpecialCentralAutoLogin.php
+++ b/includes/specials/SpecialCentralAutoLogin.php
@@ -175,6 +175,10 @@
if ( $remember != $user->getBoolOption( 
'rememberpassword' ) ) {
$user->setOption( 'rememberpassword', 
$remember ? 1 : 0 );
DeferredUpdates::addCallableUpdate( 
function() use ( $user ) {
+   if ( wfReadOnly() ) {
+   return; // not possible 
to save
+   }
+
$user->saveSettings();
} );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/348943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I378049213b348ab150ea66449d182e1497e4d9cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MarcoAurelio 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Check wfReadOnly() for rememberme preference callback

2017-04-19 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348943 )

Change subject: Check wfReadOnly() for rememberme preference callback
..

Check wfReadOnly() for rememberme preference callback

Change-Id: I378049213b348ab150ea66449d182e1497e4d9cb
---
M includes/specials/SpecialCentralAutoLogin.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/43/348943/1

diff --git a/includes/specials/SpecialCentralAutoLogin.php 
b/includes/specials/SpecialCentralAutoLogin.php
index 122a728..57ff39e 100644
--- a/includes/specials/SpecialCentralAutoLogin.php
+++ b/includes/specials/SpecialCentralAutoLogin.php
@@ -175,6 +175,10 @@
if ( $remember != $user->getBoolOption( 
'rememberpassword' ) ) {
$user->setOption( 'rememberpassword', 
$remember ? 1 : 0 );
DeferredUpdates::addCallableUpdate( 
function() use ( $user ) {
+   if ( wfReadOnly() ) {
+   return; // not possible 
to save
+   }
+
$user->saveSettings();
} );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/348943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I378049213b348ab150ea66449d182e1497e4d9cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits