[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Re-use internalList when building index

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Re-use internalList when building index
..


Re-use internalList when building index

Calling #getItemNode on the un-initalised internalList caused
a tree rebuild of the sub-document.

On a page with 200 references this cuts the time it takes to
render the re-use list from ~2000ms to ~1000ms.

Bug: T134975
Change-Id: I696a965e88338e1bec2a14f61dab158c56728f2e
---
M modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js 
b/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
index 186dbe3..c967379 100644
--- a/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
+++ b/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
@@ -152,7 +152,7 @@
n++;
refModel = 
ve.dm.MWReferenceModel.static.newFromReferenceNode( refNode );
view = new ve.ui.MWPreviewElement(
-   
refModel.getDocument().getInternalList().getItemNode( refModel.getListIndex() )
+   this.internalList.getItemNode( 
refModel.getListIndex() )
);
 
refGroup = refModel.getGroup();

-- 
To view, visit https://gerrit.wikimedia.org/r/320002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I696a965e88338e1bec2a14f61dab158c56728f2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Re-use internalList when building index

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320002

Change subject: Re-use internalList when building index
..

Re-use internalList when building index

Calling #getItemNode on the un-initalised internalList caused
a tree rebuild of the sub-document.

On a page with 200 references this cuts the time it takes to
render the re-use list from ~2000ms to ~1000ms.

Bug: T134975
Change-Id: I696a965e88338e1bec2a14f61dab158c56728f2e
---
M modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/02/320002/1

diff --git a/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js 
b/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
index 186dbe3..c967379 100644
--- a/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
+++ b/modules/ve-cite/ve.ui.MWReferenceSearchWidget.js
@@ -152,7 +152,7 @@
n++;
refModel = 
ve.dm.MWReferenceModel.static.newFromReferenceNode( refNode );
view = new ve.ui.MWPreviewElement(
-   
refModel.getDocument().getInternalList().getItemNode( refModel.getListIndex() )
+   this.internalList.getItemNode( 
refModel.getListIndex() )
);
 
refGroup = refModel.getGroup();

-- 
To view, visit https://gerrit.wikimedia.org/r/320002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I696a965e88338e1bec2a14f61dab158c56728f2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits