[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Fix for function mw.toolbar.insertTags in chrome and IE

2017-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/375754 )

Change subject: Fix for function mw.toolbar.insertTags in chrome and IE
..


Fix for function mw.toolbar.insertTags in chrome and IE

Bug: T164905
Change-Id: I15b60944a95f94b4a2e3b929fe4d00fe757961bd
---
M resources/ext.CodeMirror.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Niharika29: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index e58a5f3..4dd2729 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -21,7 +21,7 @@
function cmTextSelection( command, options ) {
var fn, retval;
 
-   if ( !codeMirror || codeMirror.getTextArea() !== this[ 0 ] ) {
+   if ( !codeMirror ) {
return origTextSelection.call( this, command, options );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/375754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15b60944a95f94b4a2e3b929fe4d00fe757961bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Pastakhov 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Niharika29 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Fix for function mw.toolbar.insertTags in chrome and IE

2017-09-04 Thread Pastakhov (Code Review) 
Pastakhov has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/375754 )

Change subject: Fix for function mw.toolbar.insertTags in chrome and IE
..

Fix for function mw.toolbar.insertTags in chrome and IE

Bug: T164905
Change-Id: I15b60944a95f94b4a2e3b929fe4d00fe757961bd
---
M resources/ext.CodeMirror.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/54/375754/1

diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index e58a5f3..4dd2729 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -21,7 +21,7 @@
function cmTextSelection( command, options ) {
var fn, retval;
 
-   if ( !codeMirror || codeMirror.getTextArea() !== this[ 0 ] ) {
+   if ( !codeMirror ) {
return origTextSelection.call( this, command, options );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/375754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15b60944a95f94b4a2e3b929fe4d00fe757961bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Pastakhov 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits