[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Set wikitext editing textareas to use monospace

2017-08-12 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371699 )

Change subject: Set wikitext editing textareas to use monospace
..


Set wikitext editing textareas to use monospace

Technically should follow UPO (sans, serif, or monospace,
or inherit), but UPO handling is shoddy and doesn't play
well with OOUI nesting.
I25513f17f340a3fe79eede37b07c86874d4fbc35 was an attempt to
fix this properly, but had issues.

Change-Id: Ie070b42ff156b45f2c11dfa8f689ea82b0b53624
---
M modules/ext.CollaborationKit.edit.styles.less
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Harej: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.CollaborationKit.edit.styles.less 
b/modules/ext.CollaborationKit.edit.styles.less
index e20f551..002bcf4 100644
--- a/modules/ext.CollaborationKit.edit.styles.less
+++ b/modules/ext.CollaborationKit.edit.styles.less
@@ -16,6 +16,18 @@
}
 }
 
+// Set the textareas (SpecialCreateCollaborationHub, 
CollaborationHubContentEditor,
+// CollaborationListContentEditor) to monospace instead of oojs ui usual of 
inherit
+// (sans serif)
+// Technically this should not be here, and we should be applying editfont UPO
+// classes as per EditPage::buildTextboxAttribs. Unfortunately, the CSS in core
+// for that has some issues with ooui's nesting, and so doesn't entirely work. 
So
+// we'll just do this instead:
+.page-Special_CreateCollaborationHub .oo-ui-textInputWidget textarea,
+.mw-collabkit-modifiededitform .oo-ui-textInputWidget textarea {
+   font-family: monospace;
+}
+
 .mw-ck-hub-topform {
max-width: 50em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie070b42ff156b45f2c11dfa8f689ea82b0b53624
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Isarra 
Gerrit-Reviewer: Harej 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Set wikitext editing textareas to use monospace

2017-08-12 Thread Isarra (Code Review)
Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371699 )

Change subject: Set wikitext editing textareas to use monospace
..

Set wikitext editing textareas to use monospace

Technically should follow UPO (sans, serif, or monospace,
or inherit), but UPO handling is shoddy and doesn't play
well with OOUI nesting.
I25513f17f340a3fe79eede37b07c86874d4fbc35 was an attempt to
fix this properly, but had issues.

Change-Id: Ie070b42ff156b45f2c11dfa8f689ea82b0b53624
---
M modules/ext.CollaborationKit.edit.styles.less
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/99/371699/1

diff --git a/modules/ext.CollaborationKit.edit.styles.less 
b/modules/ext.CollaborationKit.edit.styles.less
index e20f551..90491e1 100644
--- a/modules/ext.CollaborationKit.edit.styles.less
+++ b/modules/ext.CollaborationKit.edit.styles.less
@@ -16,6 +16,11 @@
}
 }
 
+.page-Special_CreateCollaborationHub .oo-ui-textInputWidget textarea,
+.mw-collabkit-modifiededitform .oo-ui-textInputWidget textarea {
+   font-family: monospace;
+}
+
 .mw-ck-hub-topform {
max-width: 50em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie070b42ff156b45f2c11dfa8f689ea82b0b53624
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Isarra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits