[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Remove $wgCollectionStyleVersion

2016-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove $wgCollectionStyleVersion
..


Remove $wgCollectionStyleVersion

It was probably more useful when it was used for CSS and Javascript.
A single PNG not so much.

Change-Id: Ieefcdbc6c72c2a2377c64d9db3d3c5d2a74f7f62
---
M Collection.hooks.php
M Collection.php
2 files changed, 1 insertion(+), 5 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Collection.hooks.php b/Collection.hooks.php
index 9f4916c..39902ab 100644
--- a/Collection.hooks.php
+++ b/Collection.hooks.php
@@ -197,7 +197,6 @@
 * @return string
 */
public static function renderBookCreatorBox( $title, $mode = '' ) {
-   global $wgCollectionStyleVersion;
global $wgOut, $wgExtensionAssetsPath, $wgRequest;
 
$imagePath = "$wgExtensionAssetsPath/Collection/images";
@@ -218,7 +217,7 @@
 
$html .= Xml::element( 'img',
array(
-   'src' => 
"$imagePath/Open_book.png?$wgCollectionStyleVersion",
+   'src' => "$imagePath/Open_book.png",
'alt' => '',
'width' => '80',
'height' => '45',
diff --git a/Collection.php b/Collection.php
index 9501c16..1002400 100644
--- a/Collection.php
+++ b/Collection.php
@@ -46,9 +46,6 @@
 
 # Configuration:
 
-/** Bump the version number every time you change any of the JavaScript files 
*/
-$wgCollectionStyleVersion = 9;
-
 /** URL of mw-serve render server */
 $wgCollectionMWServeURL = 'http://tools.pediapress.com/mw-serve/';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/311047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieefcdbc6c72c2a2377c64d9db3d3c5d2a74f7f62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: C. Scott Ananian 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Remove $wgCollectionStyleVersion

2016-09-15 Thread Chad (Code Review) 
Chad has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311047

Change subject: Remove $wgCollectionStyleVersion
..

Remove $wgCollectionStyleVersion

It was probably more useful when it was used for CSS and Javascript.
A single PNG not so much.

Change-Id: Ieefcdbc6c72c2a2377c64d9db3d3c5d2a74f7f62
---
M Collection.hooks.php
M Collection.php
2 files changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/47/311047/1

diff --git a/Collection.hooks.php b/Collection.hooks.php
index 9f4916c..39902ab 100644
--- a/Collection.hooks.php
+++ b/Collection.hooks.php
@@ -197,7 +197,6 @@
 * @return string
 */
public static function renderBookCreatorBox( $title, $mode = '' ) {
-   global $wgCollectionStyleVersion;
global $wgOut, $wgExtensionAssetsPath, $wgRequest;
 
$imagePath = "$wgExtensionAssetsPath/Collection/images";
@@ -218,7 +217,7 @@
 
$html .= Xml::element( 'img',
array(
-   'src' => 
"$imagePath/Open_book.png?$wgCollectionStyleVersion",
+   'src' => "$imagePath/Open_book.png",
'alt' => '',
'width' => '80',
'height' => '45',
diff --git a/Collection.php b/Collection.php
index 9501c16..1002400 100644
--- a/Collection.php
+++ b/Collection.php
@@ -46,9 +46,6 @@
 
 # Configuration:
 
-/** Bump the version number every time you change any of the JavaScript files 
*/
-$wgCollectionStyleVersion = 9;
-
 /** URL of mw-serve render server */
 $wgCollectionMWServeURL = 'http://tools.pediapress.com/mw-serve/';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/311047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieefcdbc6c72c2a2377c64d9db3d3c5d2a74f7f62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits