[MediaWiki-commits] [Gerrit] mediawiki...ConfirmAccount[master]: Fix PHP notice 'Only variables should be assigned by reference'

2016-11-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix PHP notice 'Only variables should be assigned by reference'
..


Fix PHP notice 'Only variables should be assigned by reference'

Tested and working. It is standard in MediaWiki to use this
syntax without reference-assignment.

Bug: T152020
Change-Id: I15b576ff7df6c42b7a48cf7e40b2fea58737ed5d
---
M backend/ConfirmAccount.class.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/backend/ConfirmAccount.class.php b/backend/ConfirmAccount.class.php
index aacc3ac..1a04f24 100644
--- a/backend/ConfirmAccount.class.php
+++ b/backend/ConfirmAccount.class.php
@@ -214,7 +214,7 @@
public static function verifyAttachment( $tmpfile, $extension ) {
global $wgVerifyMimeType, $wgMimeTypeBlacklist;
 
-   $magic =& MimeMagic::singleton(); // magically determine mime 
type
+   $magic = MimeMagic::singleton(); // magically determine mime 
type
$mime = $magic->guessMimeType( $tmpfile, false );
# check mime type, if desired
if ( $wgVerifyMimeType ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/324515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15b576ff7df6c42b7a48cf7e40b2fea58737ed5d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ConfirmAccount
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmAccount[master]: Fix PHP notice 'Only variables should be assigned by reference'

2016-11-30 Thread Seb35 (Code Review) 
Seb35 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324515

Change subject: Fix PHP notice 'Only variables should be assigned by reference'
..

Fix PHP notice 'Only variables should be assigned by reference'

Tested and working. It is standard in MediaWiki to use this
syntax without reference-assignment.

Bug: T152020
Change-Id: I15b576ff7df6c42b7a48cf7e40b2fea58737ed5d
---
M backend/ConfirmAccount.class.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmAccount 
refs/changes/15/324515/1

diff --git a/backend/ConfirmAccount.class.php b/backend/ConfirmAccount.class.php
index aacc3ac..1a04f24 100644
--- a/backend/ConfirmAccount.class.php
+++ b/backend/ConfirmAccount.class.php
@@ -214,7 +214,7 @@
public static function verifyAttachment( $tmpfile, $extension ) {
global $wgVerifyMimeType, $wgMimeTypeBlacklist;
 
-   $magic =& MimeMagic::singleton(); // magically determine mime 
type
+   $magic = MimeMagic::singleton(); // magically determine mime 
type
$mime = $magic->guessMimeType( $tmpfile, false );
# check mime type, if desired
if ( $wgVerifyMimeType ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/324515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15b576ff7df6c42b7a48cf7e40b2fea58737ed5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmAccount
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits