[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Make mailcheck suggestions more subtle

2016-10-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Make mailcheck suggestions more subtle
..


Make mailcheck suggestions more subtle

Smaller, gray instead of red.

Needed to stop re-using the standard error field.

Bug: T148970
Change-Id: I532b6087014435b1584cbc7d5ec59ae8e7a29383
---
M gateway_forms/mustache/personal_info.html.mustache
M modules/css/gateway.css
M modules/js/ext.donationInterface.validation.js
3 files changed, 16 insertions(+), 11 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/gateway_forms/mustache/personal_info.html.mustache 
b/gateway_forms/mustache/personal_info.html.mustache
index f20748a..12da095 100644
--- a/gateway_forms/mustache/personal_info.html.mustache
+++ b/gateway_forms/mustache/personal_info.html.mustache
@@ -52,5 +52,10 @@



+
+
+
+
+
 {{{ fieldError "email" }}}
 {{/ email_required }}
diff --git a/modules/css/gateway.css b/modules/css/gateway.css
index 30411b2..2f19d91 100644
--- a/modules/css/gateway.css
+++ b/modules/css/gateway.css
@@ -233,6 +233,12 @@
 display: none;
 }
 
+#emailSuggestion {
+display: none;
+color: #7c7c7c;
+font-size: 95%;
+}
+
 /* Respond to small viewport */
 @media screen and (max-width: 981px) {
 /* Overall layout */
diff --git a/modules/js/ext.donationInterface.validation.js 
b/modules/js/ext.donationInterface.validation.js
index 1e3496c..fb64986 100644
--- a/modules/js/ext.donationInterface.validation.js
+++ b/modules/js/ext.donationInterface.validation.js
@@ -115,22 +115,16 @@
'donate_interface-did-you-mean',
suggestion.full
);
-   $( '#emailMsg' )
-   .removeClass( 'errorMsgHide' )
-   .addClass( 'errorMsg' )
-   .html( message );
+   $( '#emailSuggestion' ).show();
+   $( '#emailSuggestion span' ).html( message );
},
empty: function ( element ) {
-   $( '#emailMsg' )
-   .removeClass( 'errorMsg' )
-   .addClass( 'errorMsgHide' );
+   $( '#emailSuggestion' ).hide();
}
} );
} );
-   $( document ).on( 'click', '#emailMsg .correction', function () {
+   $( document ).on( 'click', '#emailSuggestion .correction', function () {
$( '#email' ).val( $( this ).text() );
-   $( '#emailMsg' )
-   .removeClass( 'errorMsg' )
-   .addClass( 'errorMsgHide' );
+   $( '#emailSuggestion' ).hide();
} );
 } )( jQuery, mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/317581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I532b6087014435b1584cbc7d5ec59ae8e7a29383
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Make mailcheck suggestions more subtle

2016-10-24 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/317581

Change subject: Make mailcheck suggestions more subtle
..

Make mailcheck suggestions more subtle

Smaller, gray instead of red.

Bug: T148970
Change-Id: I532b6087014435b1584cbc7d5ec59ae8e7a29383
---
M gateway_forms/mustache/personal_info.html.mustache
M modules/css/gateway.css
M modules/js/ext.donationInterface.validation.js
3 files changed, 16 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/81/317581/1

diff --git a/gateway_forms/mustache/personal_info.html.mustache 
b/gateway_forms/mustache/personal_info.html.mustache
index f20748a..12da095 100644
--- a/gateway_forms/mustache/personal_info.html.mustache
+++ b/gateway_forms/mustache/personal_info.html.mustache
@@ -52,5 +52,10 @@



+
+
+
+
+
 {{{ fieldError "email" }}}
 {{/ email_required }}
diff --git a/modules/css/gateway.css b/modules/css/gateway.css
index 30411b2..2f19d91 100644
--- a/modules/css/gateway.css
+++ b/modules/css/gateway.css
@@ -233,6 +233,12 @@
 display: none;
 }
 
+#emailSuggestion {
+display: none;
+color: #7c7c7c;
+font-size: 95%;
+}
+
 /* Respond to small viewport */
 @media screen and (max-width: 981px) {
 /* Overall layout */
diff --git a/modules/js/ext.donationInterface.validation.js 
b/modules/js/ext.donationInterface.validation.js
index 1e3496c..fb64986 100644
--- a/modules/js/ext.donationInterface.validation.js
+++ b/modules/js/ext.donationInterface.validation.js
@@ -115,22 +115,16 @@
'donate_interface-did-you-mean',
suggestion.full
);
-   $( '#emailMsg' )
-   .removeClass( 'errorMsgHide' )
-   .addClass( 'errorMsg' )
-   .html( message );
+   $( '#emailSuggestion' ).show();
+   $( '#emailSuggestion span' ).html( message );
},
empty: function ( element ) {
-   $( '#emailMsg' )
-   .removeClass( 'errorMsg' )
-   .addClass( 'errorMsgHide' );
+   $( '#emailSuggestion' ).hide();
}
} );
} );
-   $( document ).on( 'click', '#emailMsg .correction', function () {
+   $( document ).on( 'click', '#emailSuggestion .correction', function () {
$( '#email' ).val( $( this ).text() );
-   $( '#emailMsg' )
-   .removeClass( 'errorMsg' )
-   .addClass( 'errorMsgHide' );
+   $( '#emailSuggestion' ).hide();
} );
 } )( jQuery, mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/317581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I532b6087014435b1584cbc7d5ec59ae8e7a29383
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits