[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove deprecated function

2017-04-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/341721 )

Change subject: Remove deprecated function
..


Remove deprecated function

Change-Id: I2a36b910b7181fc4db101bfd90cdbb41cf372181
---
M gateway_common/DonationData.php
1 file changed, 0 insertions(+), 16 deletions(-)

Approvals:
  jenkins-bot: Verified
  Ejegg: Looks good to me, approved



diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index 96a2650..07c6d43 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -1015,22 +1015,6 @@
return $this->validationErrors;
}
 
-   /**
-* validatedOK
-* Checks to see if the data validated ok (no errors).
-* @return boolean True if no errors, false if errors exist.
-*/
-   public function validatedOK() {
-   if ( is_null( $this->validationErrors ) ) {
-   $this->getValidationErrors();
-   }
-
-   if ( count( $this->validationErrors ) === 0 ) {
-   return true;
-   }
-   return false;
-   }
-
private function expungeNulls() {
foreach ( $this->normalized as $key => $val ) {
if ( is_null( $val ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/341721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a36b910b7181fc4db101bfd90cdbb41cf372181
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove deprecated function

2017-03-07 Thread Awight (Code Review) 
Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/341721 )

Change subject: Remove deprecated function
..

Remove deprecated function

Change-Id: I2a36b910b7181fc4db101bfd90cdbb41cf372181
---
M gateway_common/DonationData.php
1 file changed, 0 insertions(+), 16 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/21/341721/1

diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index 96a2650..07c6d43 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -1015,22 +1015,6 @@
return $this->validationErrors;
}
 
-   /**
-* validatedOK
-* Checks to see if the data validated ok (no errors).
-* @return boolean True if no errors, false if errors exist.
-*/
-   public function validatedOK() {
-   if ( is_null( $this->validationErrors ) ) {
-   $this->getValidationErrors();
-   }
-
-   if ( count( $this->validationErrors ) === 0 ) {
-   return true;
-   }
-   return false;
-   }
-
private function expungeNulls() {
foreach ( $this->normalized as $key => $val ) {
if ( is_null( $val ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/341721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a36b910b7181fc4db101bfd90cdbb41cf372181
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits