[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.29.0-wmf.7]: Pass 2 parameters to addDeprecation

2017-01-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330743 )

Change subject: Pass 2 parameters to addDeprecation
..


Pass 2 parameters to addDeprecation

Change-Id: I891f94d32d64296fdb121d632e94dfba4b09070f
---
M includes/api/ApiEchoMarkSeen.php
M includes/api/ApiEchoNotifications.php
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/api/ApiEchoMarkSeen.php b/includes/api/ApiEchoMarkSeen.php
index c122757..d06852a 100644
--- a/includes/api/ApiEchoMarkSeen.php
+++ b/includes/api/ApiEchoMarkSeen.php
@@ -20,7 +20,7 @@
$outputTimestamp = wfTimestamp( TS_ISO_8601, $timestamp 
);
} else {
// MW
-   $this->addDeprecation( 
'apiwarn-echo-deprecation-timestampformat' );
+   $this->addDeprecation( 
'apiwarn-echo-deprecation-timestampformat', 
'action=echomarkseen=MW' );
 
$outputTimestamp = $timestamp;
}
diff --git a/includes/api/ApiEchoNotifications.php 
b/includes/api/ApiEchoNotifications.php
index cd9d37c..f5b63b8 100644
--- a/includes/api/ApiEchoNotifications.php
+++ b/includes/api/ApiEchoNotifications.php
@@ -23,9 +23,9 @@
 
/* @deprecated */
if ( $params['format'] === 'flyout' ) {
-   $this->addDeprecation( 
'apiwarn-echo-deprecation-flyout' );
+   $this->addDeprecation( 
'apiwarn-echo-deprecation-flyout', 
'action=query=notifications=flyout' );
} elseif ( $params['format'] === 'html' ) {
-   $this->addDeprecation( 'apiwarn-echo-deprecation-html' 
);
+   $this->addDeprecation( 'apiwarn-echo-deprecation-html', 
'action=query=notifications=html' );
}
 
if ( $this->allowCrossWikiNotifications() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/330743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I891f94d32d64296fdb121d632e94dfba4b09070f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.29.0-wmf.7
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.29.0-wmf.7]: Pass 2 parameters to addDeprecation

2017-01-05 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330743 )

Change subject: Pass 2 parameters to addDeprecation
..

Pass 2 parameters to addDeprecation

Change-Id: I891f94d32d64296fdb121d632e94dfba4b09070f
---
M includes/api/ApiEchoMarkSeen.php
M includes/api/ApiEchoNotifications.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/43/330743/1

diff --git a/includes/api/ApiEchoMarkSeen.php b/includes/api/ApiEchoMarkSeen.php
index c122757..d06852a 100644
--- a/includes/api/ApiEchoMarkSeen.php
+++ b/includes/api/ApiEchoMarkSeen.php
@@ -20,7 +20,7 @@
$outputTimestamp = wfTimestamp( TS_ISO_8601, $timestamp 
);
} else {
// MW
-   $this->addDeprecation( 
'apiwarn-echo-deprecation-timestampformat' );
+   $this->addDeprecation( 
'apiwarn-echo-deprecation-timestampformat', 
'action=echomarkseen=MW' );
 
$outputTimestamp = $timestamp;
}
diff --git a/includes/api/ApiEchoNotifications.php 
b/includes/api/ApiEchoNotifications.php
index cd9d37c..f5b63b8 100644
--- a/includes/api/ApiEchoNotifications.php
+++ b/includes/api/ApiEchoNotifications.php
@@ -23,9 +23,9 @@
 
/* @deprecated */
if ( $params['format'] === 'flyout' ) {
-   $this->addDeprecation( 
'apiwarn-echo-deprecation-flyout' );
+   $this->addDeprecation( 
'apiwarn-echo-deprecation-flyout', 
'action=query=notifications=flyout' );
} elseif ( $params['format'] === 'html' ) {
-   $this->addDeprecation( 'apiwarn-echo-deprecation-html' 
);
+   $this->addDeprecation( 'apiwarn-echo-deprecation-html', 
'action=query=notifications=html' );
}
 
if ( $this->allowCrossWikiNotifications() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/330743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I891f94d32d64296fdb121d632e94dfba4b09070f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.29.0-wmf.7
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits