Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/363957 )
Change subject: Only subscribe EventLogging once
......................................................................
Only subscribe EventLogging once
Do not subscribe again on subsequent load events
Bug: T170018
Change-Id: I21b60a581b9dd3c4f4473c711941b6c28f7f7f0e
---
M modules/ext.eventLogging.subscriber.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/57/363957/1
diff --git a/modules/ext.eventLogging.subscriber.js
b/modules/ext.eventLogging.subscriber.js
index e569ae7..a287ae4 100644
--- a/modules/ext.eventLogging.subscriber.js
+++ b/modules/ext.eventLogging.subscriber.js
@@ -87,7 +87,9 @@
};
- $( window ).on( 'load', function () {
+ // The load event fires on certain back button presses so we only
subscribe to this once.
+ // Otherwise duplicate events will be logged (T170018).
+ $( window ).one( 'load', function () {
mw.trackSubscribe( 'event.', handleTrackedEvent );
} );
--
To view, visit https://gerrit.wikimedia.org/r/363957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21b60a581b9dd3c4f4473c711941b6c28f7f7f0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
