[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Don't autopatrol autoreviewed users in protection-based configs

2016-12-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Don't autopatrol autoreviewed users in protection-based configs
..


Don't autopatrol autoreviewed users in protection-based configs

This no longer autopatrols autoreviewed users in protection-based
configs, since on wikis with those configs the autopatrolled
permission requires a much higher level of trust than the
autoreviewed permission. And when not using RC patrol, log entries
for autopatrols were created that were not for new pages hence
didn't make sense to end users.

Bug: T150086
Change-Id: Ia0565c7aabffc1a53bb5b5486699fceba192c38c
---
M backend/FlaggedRevs.hooks.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/backend/FlaggedRevs.hooks.php b/backend/FlaggedRevs.hooks.php
index a669280..ea19fa7 100755
--- a/backend/FlaggedRevs.hooks.php
+++ b/backend/FlaggedRevs.hooks.php
@@ -637,6 +637,12 @@
if ( empty( $rc->mAttribs['rc_this_oldid'] ) ) {
return true;
}
+   // don't autopatrol autoreviewed edits when using pending 
changes,
+   // otherwise edits by autoreviewed users on pending changes 
protected pages would be
+   // autopatrolled and could not be checked through RC patrol as 
on regular pages
+   if ( FlaggedRevs::useOnlyIfProtected() ) {
+   return true;
+   }
$fa = FlaggableWikiPage::getTitleInstance( $rc->getTitle() );
$fa->loadPageData( 'fromdbmaster' );
// Is the page reviewable?

-- 
To view, visit https://gerrit.wikimedia.org/r/315109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0565c7aabffc1a53bb5b5486699fceba192c38c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Cenarium 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Don't autopatrol autoreviewed users in protection-based configs

2016-10-10 Thread Cenarium (Code Review) 
Cenarium has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315109

Change subject: Don't autopatrol autoreviewed users in protection-based configs
..

Don't autopatrol autoreviewed users in protection-based configs

Autoreviewed users are no longer patrolled in protection-based configs
since when using RC patrol, it implies that autoreviewed users
are autopatrolled on pages with pending changes, but not on others.
This prevents regular patrol of those users, who often are merely
autoconfirmed, on pending changes protected pages. On those wikis,
the autopatrolled permission requires a much higher level of trust.

Change-Id: Ia0565c7aabffc1a53bb5b5486699fceba192c38c
---
M backend/FlaggedRevs.hooks.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/09/315109/1

diff --git a/backend/FlaggedRevs.hooks.php b/backend/FlaggedRevs.hooks.php
index a669280..ea19fa7 100755
--- a/backend/FlaggedRevs.hooks.php
+++ b/backend/FlaggedRevs.hooks.php
@@ -637,6 +637,12 @@
if ( empty( $rc->mAttribs['rc_this_oldid'] ) ) {
return true;
}
+   // don't autopatrol autoreviewed edits when using pending 
changes,
+   // otherwise edits by autoreviewed users on pending changes 
protected pages would be
+   // autopatrolled and could not be checked through RC patrol as 
on regular pages
+   if ( FlaggedRevs::useOnlyIfProtected() ) {
+   return true;
+   }
$fa = FlaggableWikiPage::getTitleInstance( $rc->getTitle() );
$fa->loadPageData( 'fromdbmaster' );
// Is the page reviewable?

-- 
To view, visit https://gerrit.wikimedia.org/r/315109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0565c7aabffc1a53bb5b5486699fceba192c38c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Cenarium 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits