[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix CheckUser type check thingy

2018-01-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398178 )

Change subject: Fix CheckUser type check thingy
..


Fix CheckUser type check thingy

CheckUser changed in I39c60b2d059d1cb2c1c0d3a4206232d961536697

Bug: T182834
Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
---
M Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified

Objections:
  Thiemo Kreuz (WMDE): There's a problem with this change, please improve



diff --git a/Hooks.php b/Hooks.php
index 0034c0b..7d22c40 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -556,7 +556,7 @@
}
}
 
-   public static function onSpecialCheckUserGetLinksFromRow( CheckUser 
$checkUser, $row, &$links ) {
+   public static function onSpecialCheckUserGetLinksFromRow( 
SpecialCheckUser $checkUser, $row, &$links ) {
if ( !$row->cuc_type == RC_FLOW ) {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Thiemo Kreuz (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix CheckUser type check thingy

2017-12-13 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398178 )

Change subject: Fix CheckUser type check thingy
..

Fix CheckUser type check thingy

CheckUser changed in I39c60b2d059d1cb2c1c0d3a4206232d961536697

Bug: T182834
Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
---
M Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/78/398178/1

diff --git a/Hooks.php b/Hooks.php
index 0034c0b..7d22c40 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -556,7 +556,7 @@
}
}
 
-   public static function onSpecialCheckUserGetLinksFromRow( CheckUser 
$checkUser, $row, &$links ) {
+   public static function onSpecialCheckUserGetLinksFromRow( 
SpecialCheckUser $checkUser, $row, &$links ) {
if ( !$row->cuc_type == RC_FLOW ) {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits