[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Get rid of useless $mediafile_namespace Config setting

2017-07-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363544 )

Change subject: Get rid of useless $mediafile_namespace Config setting
..


Get rid of useless $mediafile_namespace Config setting

It's always going to be NS_FILE.

Also fix a @see comment.

Change-Id: Icf8a0b707f3499eebfc167595b7d57c05dc7403e
---
M includes/Config.php
M includes/Handlers/UploadHandler.php
2 files changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Brian Wolff: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/includes/Config.php b/includes/Config.php
index d26812b..d278a58 100644
--- a/includes/Config.php
+++ b/includes/Config.php
@@ -115,12 +115,6 @@
 
/**
 * @var {string}
-* wiki namespace to store metadata mappings and data sets
-*/
-   public static $mediafile_namespace = NS_FILE;
-
-   /**
-* @var {string}
 * 128M default
 */
public static $memory_limit = '256M';
@@ -229,7 +223,7 @@
/**
 * @var {array}
 * user permissions required in order to be able to use this extension
-* @see GWToolset\Helpers\WikiChecks\checkUserPermissions
+* @see \GWToolset\Helpers\WikiChecks::checkUserPermissions
 */
public static $user_permissions = [
'edit',
diff --git a/includes/Handlers/UploadHandler.php 
b/includes/Handlers/UploadHandler.php
index 16817ca..ca4096b 100644
--- a/includes/Handlers/UploadHandler.php
+++ b/includes/Handlers/UploadHandler.php
@@ -518,7 +518,7 @@
protected function getTitle( $title ) {
$result = Utils::getTitle(
Utils::stripIllegalTitleChars( $title ),
-   Config::$mediafile_namespace,
+   NS_FILE,
[ 'must-be-known' => false ]
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf8a0b707f3499eebfc167595b7d57c05dc7403e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Get rid of useless $mediafile_namespace Config setting

2017-07-06 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363544 )

Change subject: Get rid of useless $mediafile_namespace Config setting
..

Get rid of useless $mediafile_namespace Config setting

It's always going to be NS_FILE.

Also fix a @see comment.

Change-Id: Icf8a0b707f3499eebfc167595b7d57c05dc7403e
---
M includes/Config.php
M includes/Handlers/UploadHandler.php
2 files changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GWToolset 
refs/changes/44/363544/1

diff --git a/includes/Config.php b/includes/Config.php
index d26812b..d278a58 100644
--- a/includes/Config.php
+++ b/includes/Config.php
@@ -115,12 +115,6 @@
 
/**
 * @var {string}
-* wiki namespace to store metadata mappings and data sets
-*/
-   public static $mediafile_namespace = NS_FILE;
-
-   /**
-* @var {string}
 * 128M default
 */
public static $memory_limit = '256M';
@@ -229,7 +223,7 @@
/**
 * @var {array}
 * user permissions required in order to be able to use this extension
-* @see GWToolset\Helpers\WikiChecks\checkUserPermissions
+* @see \GWToolset\Helpers\WikiChecks::checkUserPermissions
 */
public static $user_permissions = [
'edit',
diff --git a/includes/Handlers/UploadHandler.php 
b/includes/Handlers/UploadHandler.php
index 16817ca..ca4096b 100644
--- a/includes/Handlers/UploadHandler.php
+++ b/includes/Handlers/UploadHandler.php
@@ -518,7 +518,7 @@
protected function getTitle( $title ) {
$result = Utils::getTitle(
Utils::stripIllegalTitleChars( $title ),
-   Config::$mediafile_namespace,
+   NS_FILE,
[ 'must-be-known' => false ]
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf8a0b707f3499eebfc167595b7d57c05dc7403e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits