[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Remove more useless Config settings related to Special:GWToo...

2017-07-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363545 )

Change subject: Remove more useless Config settings related to Special:GWToolset
..


Remove more useless Config settings related to Special:GWToolset

Hardcode that the 'gwtoolset' permission is required for the special
page. If someone wants to modify the permissions, they can grant that
right to different groups.

And just make the special page always listed. It's not really something
that needs to be configured, and no other extension does it.

Change-Id: I6817e71a5bfe0a7aea989c8ff691fa8a379df9a3
---
M includes/Config.php
M includes/Specials/SpecialGWToolset.php
2 files changed, 1 insertion(+), 16 deletions(-)

Approvals:
  Brian Wolff: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/includes/Config.php b/includes/Config.php
index d278a58..4f8cbf7 100644
--- a/includes/Config.php
+++ b/includes/Config.php
@@ -188,20 +188,6 @@
public static $source_templates = 'Source_templates';
 
/**
-* @see SpecialPage __constructor
-* @var {string}
-* user right required, e.g. "block" or "delete"
-*/
-   public static $special_page_restriction = 'gwtoolset';
-
-   /**
-* @see SpecialPage __constructor
-* @var {bool}
-* whether the page is listed in Special:Specialpages
-*/
-   public static $special_page_listed = true;
-
-   /**
 * @var {int}
 * title maximum length in bytes
 * @see https://commons.wikimedia.org/wiki/Commons:File_naming
diff --git a/includes/Specials/SpecialGWToolset.php 
b/includes/Specials/SpecialGWToolset.php
index a23c66a..7a7bedf 100644
--- a/includes/Specials/SpecialGWToolset.php
+++ b/includes/Specials/SpecialGWToolset.php
@@ -53,8 +53,7 @@
public function __construct() {
parent::__construct(
Constants::EXTENSION_NAME,
-   Config::$special_page_restriction,
-   Config::$special_page_listed
+   'gwtoolset'
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6817e71a5bfe0a7aea989c8ff691fa8a379df9a3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Remove more useless Config settings related to Special:GWToo...

2017-07-06 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363545 )

Change subject: Remove more useless Config settings related to Special:GWToolset
..

Remove more useless Config settings related to Special:GWToolset

Hardcode that the 'gwtoolset' permission is required for the special
page. If someone wants to modify the permissions, they can grant that
right to different groups.

And just make the special page always listed. It's not really something
that needs to be configured, and no other extension does it.

Change-Id: I6817e71a5bfe0a7aea989c8ff691fa8a379df9a3
---
M includes/Config.php
M includes/Specials/SpecialGWToolset.php
2 files changed, 1 insertion(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GWToolset 
refs/changes/45/363545/1

diff --git a/includes/Config.php b/includes/Config.php
index d278a58..4f8cbf7 100644
--- a/includes/Config.php
+++ b/includes/Config.php
@@ -188,20 +188,6 @@
public static $source_templates = 'Source_templates';
 
/**
-* @see SpecialPage __constructor
-* @var {string}
-* user right required, e.g. "block" or "delete"
-*/
-   public static $special_page_restriction = 'gwtoolset';
-
-   /**
-* @see SpecialPage __constructor
-* @var {bool}
-* whether the page is listed in Special:Specialpages
-*/
-   public static $special_page_listed = true;
-
-   /**
 * @var {int}
 * title maximum length in bytes
 * @see https://commons.wikimedia.org/wiki/Commons:File_naming
diff --git a/includes/Specials/SpecialGWToolset.php 
b/includes/Specials/SpecialGWToolset.php
index a23c66a..7a7bedf 100644
--- a/includes/Specials/SpecialGWToolset.php
+++ b/includes/Specials/SpecialGWToolset.php
@@ -53,8 +53,7 @@
public function __construct() {
parent::__construct(
Constants::EXTENSION_NAME,
-   Config::$special_page_restriction,
-   Config::$special_page_listed
+   'gwtoolset'
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6817e71a5bfe0a7aea989c8ff691fa8a379df9a3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits