[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Augment event logging for switching layers

2017-07-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366183 )

Change subject: Augment event logging for switching layers
..


Augment event logging for switching layers

We want to be able to tell which layer specifically the user
selected to differentiate between mapnik and relief layers.

Bug: T171020
Change-Id: Id196bdc43aed666573722a73ece41301db364cfd
---
M modules/wikivoyage/WVMapLayers.js
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/wikivoyage/WVMapLayers.js 
b/modules/wikivoyage/WVMapLayers.js
index 114e577..0f82b8f 100644
--- a/modules/wikivoyage/WVMapLayers.js
+++ b/modules/wikivoyage/WVMapLayers.js
@@ -24,7 +24,12 @@
mw.track( 'mediawiki.kartographer', {
action: ( event.layer === map.wikimediaLayer ) 
? 'wv-select-wmflayer' : 'wv-select-exlayer',
isFullScreen: !!map.options.fullscreen,
-   feature: map
+   feature: map,
+   options: {
+   extra: {
+   layer: 
event.layer.options.wvName
+   }
+   }
} );
} );
 
@@ -47,7 +52,12 @@
mw.track( 'mediawiki.kartographer', {
action: eventName,
isFullScreen: !!map.options.fullscreen,
-   feature: map
+   feature: map,
+   options: {
+   extra: {
+   layer: 
event.layer.options.wvName
+   }
+   }
} );
} );
};

-- 
To view, visit https://gerrit.wikimedia.org/r/366183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id196bdc43aed666573722a73ece41301db364cfd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Bearloga 
Gerrit-Reviewer: Bearloga 
Gerrit-Reviewer: Jdrewniak 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Pnorman 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Augment event logging for switching layers

2017-07-18 Thread Bearloga (Code Review) 
Bearloga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366183 )

Change subject: Augment event logging for switching layers
..

Augment event logging for switching layers

Bug: T171020
Change-Id: Id196bdc43aed666573722a73ece41301db364cfd
---
M modules/wikivoyage/WVMapLayers.js
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/83/366183/1

diff --git a/modules/wikivoyage/WVMapLayers.js 
b/modules/wikivoyage/WVMapLayers.js
index 114e577..2a7c4d2 100644
--- a/modules/wikivoyage/WVMapLayers.js
+++ b/modules/wikivoyage/WVMapLayers.js
@@ -24,7 +24,12 @@
mw.track( 'mediawiki.kartographer', {
action: ( event.layer === map.wikimediaLayer ) 
? 'wv-select-wmflayer' : 'wv-select-exlayer',
isFullScreen: !!map.options.fullscreen,
-   feature: map
+   feature: map,
+   options: {
+   extra: {
+   layer: event.layer // assumes 
event.layer holds the (string) name of the layer, maybe need to use 
event.layer.name?
+   }
+   }
} );
} );
 
@@ -47,7 +52,12 @@
mw.track( 'mediawiki.kartographer', {
action: eventName,
isFullScreen: !!map.options.fullscreen,
-   feature: map
+   feature: map,
+   options: {
+   extra: {
+   layer: event.layer // assumes 
event.layer holds the (string) name of the layer, maybe need to use 
event.layer.name?
+   }
+   }
} );
} );
};

-- 
To view, visit https://gerrit.wikimedia.org/r/366183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id196bdc43aed666573722a73ece41301db364cfd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Bearloga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits