[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Remove href attribute (non-js fallback) once the map is inte...

2017-02-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/339789 )

Change subject: Remove href attribute (non-js fallback) once the map is 
interactive
..


Remove href attribute (non-js fallback) once the map is interactive

Bug: T158979
Change-Id: Ib07cb4408e28bacfd7e6335d562c3c0a808b0e81
---
M modules/mapframe/mapframe.js
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/mapframe/mapframe.js b/modules/mapframe/mapframe.js
index 6f7e94b..dfc01cc 100644
--- a/modules/mapframe/mapframe.js
+++ b/modules/mapframe/mapframe.js
@@ -95,6 +95,9 @@
dataGroups: data.overlays,
captionText: data.captionText
} );
+
+   $container.removeAttr( 'href' );
+
mw.track( 'mediawiki.kartographer', {
action: 'view',
isFullScreen: false,

-- 
To view, visit https://gerrit.wikimedia.org/r/339789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib07cb4408e28bacfd7e6335d562c3c0a808b0e81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Remove href attribute (non-js fallback) once the map is inte...

2017-02-24 Thread JGirault (Code Review) 
JGirault has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/339789 )

Change subject: Remove href attribute (non-js fallback) once the map is 
interactive
..

Remove href attribute (non-js fallback) once the map is interactive

Bug: T158979
Change-Id: Ib07cb4408e28bacfd7e6335d562c3c0a808b0e81
---
M modules/mapframe/mapframe.js
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/89/339789/1

diff --git a/modules/mapframe/mapframe.js b/modules/mapframe/mapframe.js
index 6f7e94b..dfc01cc 100644
--- a/modules/mapframe/mapframe.js
+++ b/modules/mapframe/mapframe.js
@@ -95,6 +95,9 @@
dataGroups: data.overlays,
captionText: data.captionText
} );
+
+   $container.removeAttr( 'href' );
+
mw.track( 'mediawiki.kartographer', {
action: 'view',
isFullScreen: false,

-- 
To view, visit https://gerrit.wikimedia.org/r/339789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib07cb4408e28bacfd7e6335d562c3c0a808b0e81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits