[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix fullscreen map not closing properly
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/327012 ) Change subject: Fix fullscreen map not closing properly .. Fix fullscreen map not closing properly Bug: T153100 Change-Id: I6288b79483962f06b031e9b77f19826c1f311525 --- M modules/dialog/index.js 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yurik: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/dialog/index.js b/modules/dialog/index.js index 683da45..b735471 100644 --- a/modules/dialog/index.js +++ b/modules/dialog/index.js @@ -98,6 +98,7 @@ if ( map.useRouter && !routerEnabled ) { router.on( 'route', closeIfNotMapRoute ); + router.route( '', closeIfNotMapRoute ); routerEnabled = true; } -- To view, visit https://gerrit.wikimedia.org/r/327012 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6288b79483962f06b031e9b77f19826c1f311525 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Kartographer Gerrit-Branch: master Gerrit-Owner: JGirault Gerrit-Reviewer: Yurik Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix fullscreen map not closing properly
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327012 ) Change subject: Fix fullscreen map not closing properly .. Fix fullscreen map not closing properly Bug: T153100 Change-Id: I6288b79483962f06b031e9b77f19826c1f311525 --- M modules/dialog/index.js 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer refs/changes/12/327012/1 diff --git a/modules/dialog/index.js b/modules/dialog/index.js index 683da45..b735471 100644 --- a/modules/dialog/index.js +++ b/modules/dialog/index.js @@ -98,6 +98,7 @@ if ( map.useRouter && !routerEnabled ) { router.on( 'route', closeIfNotMapRoute ); + router.route( '', closeIfNotMapRoute ); routerEnabled = true; } -- To view, visit https://gerrit.wikimedia.org/r/327012 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6288b79483962f06b031e9b77f19826c1f311525 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Kartographer Gerrit-Branch: master Gerrit-Owner: JGirault ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits